929825 - mozharness sendchange hits unicode errors

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Aki Sasaki (not active)]

Options:
* fix buildbot sendchange to accept unicode
* only sendchange the comment if it's a try build (this only reduces the occurrence, doesn't eliminate it)
* ascii-fy the comment before sendchanging (this is probably the easiest fix)

16:31:07     INFO - Running command: ['/tools/buildbot/bin/buildbot', 'sendchange', '--master', 'buildbot-master81.build.mozilla.org:9301', '--username', 'sendchange-unittest', '--branch', u'mozilla-aurora-emulator-opt-unittest', '-r', u'bb33e2fe109cd251a9f2ca01bfd2e75e5fc7798d', '--username', u'ffxbld', '--comments', u"Bumping gaia.json for 3 gaia-1_2 revision(s) a=gaia-bump\n\n========\n\nhttps://hg.mozilla.org/integration/gaia-1_2/rev/57fe603003a4\nAuthor: Fabrice Desr\xe9 <[e-mail]>\nDesc: Bug 924032 - ~40ms delay from app.launch to mozChromeEvent r=vingtetun\n(cherry picked from commit 2b10e0af4c96568a2726f09d17b549e6608f83ff)\n\n========\n\nhttps://hg.mozilla.org/integration/gaia-1_2/rev/224a1b1d9db7\nAuthor: Ghislain 'Aus' Lacroix <[e-mail]>\nDesc: Merge pull request #12948 from nullaus/awesome-bar-ui\n\nbug 925970\n\n========\n\nhttps://hg.mozilla.org/integration/gaia-1_2/rev/45fb80826ec8\nAuthor: Ghislain 'Aus' Lacroix <[e-mail]>\nDesc: bug 925970\n\n* Refresh visual design for e.me search bar\n* Changes are for v1.2 branch, master will require a re-base and further icon design work.\n* Addressed review comments: fixed 2 regressions.\n\nr=[e-mail]", '--property', u'builduid:853d25e4cc3342daa9d0a39f3551fffb', '--property', 'buildid:20131022143553', '--property', 'pgo_build:False', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/emulator.tar.gz', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/b2g-26.0a2.en-US.android-arm.crashreporter-symbols.zip', u'http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/b2g-26.0a2.en-US.android-arm.tests.zip']
16:31:07     INFO - Copy/paste: /tools/buildbot/bin/buildbot sendchange --master buildbot-master81.build.mozilla.org:9301 --username sendchange-unittest --branch mozilla-aurora-emulator-opt-unittest -r bb33e2fe109cd251a9f2ca01bfd2e75e5fc7798d --username ffxbld --comments "Bumping gaia.json for 3 gaia-1_2 revision(s) a=gaia-bump
16:31:07     INFO - 
16:31:07     INFO - ========
16:31:07     INFO - 
16:31:07     INFO - https://hg.mozilla.org/integration/gaia-1_2/rev/57fe603003a4
16:31:07     INFO - Author: Fabrice Desré <[e-mail]>
16:31:07     INFO - Desc: Bug 924032 - ~40ms delay from app.launch to mozChromeEvent r=vingtetun
16:31:07     INFO - (cherry picked from commit 2b10e0af4c96568a2726f09d17b549e6608f83ff)
16:31:07     INFO - 
16:31:07     INFO - ========
16:31:07     INFO - 
16:31:07     INFO - https://hg.mozilla.org/integration/gaia-1_2/rev/224a1b1d9db7
16:31:07     INFO - Author: Ghislain 'Aus' Lacroix <[e-mail]>
16:31:07     INFO - Desc: Merge pull request #12948 from nullaus/awesome-bar-ui
16:31:07     INFO - 
16:31:07     INFO - bug 925970
16:31:07     INFO - 
16:31:07     INFO - ========
16:31:07     INFO - 
16:31:07     INFO - https://hg.mozilla.org/integration/gaia-1_2/rev/45fb80826ec8
16:31:07     INFO - Author: Ghislain 'Aus' Lacroix <[e-mail]>
16:31:07     INFO - Desc: bug 925970
16:31:07     INFO - 
16:31:07     INFO - * Refresh visual design for e.me search bar
16:31:07     INFO - * Changes are for v1.2 branch, master will require a re-base and further icon design work.
16:31:07     INFO - * Addressed review comments: fixed 2 regressions.
16:31:07     INFO - 
16:31:07     INFO - r=[e-mail]" --property builduid:853d25e4cc3342daa9d0a39f3551fffb --property buildid:20131022143553 --property pgo_build:False http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/emulator.tar.gz http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/b2g-26.0a2.en-US.android-arm.crashreporter-symbols.zip http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-aurora-generic/20131022143553/b2g-26.0a2.en-US.android-arm.tests.zip
16:31:08     INFO -  NOTE: --username/-u is deprecated: use --who/-W'
16:31:08     INFO -  change(s) NOT sent, something went wrong: [Failure instance: Traceback from remote host -- Traceback (most recent call last):
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/banana.py", line 153, in gotItem
16:31:08     INFO -      self.callExpressionReceived(item)
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/banana.py", line 116, in callExpressionReceived
16:31:08     INFO -      self.expressionReceived(obj)
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/pb.py", line 514, in expressionReceived
16:31:08     INFO -      method(*sexp[1:])
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/pb.py", line 826, in proto_message
16:31:08     INFO -      self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw)
16:31:08     INFO -  --- <exception caught here> ---
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/pb.py", line 840, in _recvMessage
16:31:08     INFO -      netResult = object.remoteMessageReceived(self, message, netArgs, netKw)
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/twisted/spread/pb.py", line 225, in perspectiveMessageReceived
16:31:08     INFO -      state = method(*args, **kw)
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/changes/pb.py", line 43, in perspective_addChange
16:31:08     INFO -      self.changemaster.addChange(change)
16:31:08     INFO -    File "/builds/buildbot/build_scheduler/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/changes/manager.py", line 108, in addChange
16:31:08     INFO -      change.comments, change.category, change.project))
16:31:08     INFO -  exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 149: ordinal not in range(128)
16:31:08     INFO -  ]
16:31:08    ERROR - Return code: 1

Comment 1

[[e-mail] (:bhearsum)]

Attachment: force comments to be ascii

Untested.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8359970 [details] [diff] [review]
force comments to be ascii

I think that works in my limited testing.

Comment 4

[[e-mail] (:bhearsum)]

in production