Closed
Bug 929868
Opened 12 years ago
Closed 12 years ago
pretty print button is smaller than all other buttons
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.12 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Every other button is 32px wide, while the pretty print button is smaller.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #820798 -
Flags: review?(vporof)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Need the patch from bug 917072 or else this patch will probably not apply. Doesn't technically "depend" on it though.
Depends on: 917072
|
||
Comment 3•12 years ago
|
||
Comment on attachment 820798 [details] [diff] [review]
pp-button.patch
Review of attachment 820798 [details] [diff] [review]:
-----------------------------------------------------------------
I don't think you attached the right patch.
Attachment #820798 -
Flags: review?(vporof)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Woops!
Attachment #820798 -
Attachment is obsolete: true
Attachment #821091 -
Flags: review?(vporof)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 821091 [details] [diff] [review]
pp-button.patch
Review of attachment 821091 [details] [diff] [review]:
-----------------------------------------------------------------
It'd be safer if you set a min-width to all toolbarbuttons in the #sources-toolbar.
Attachment #821091 -
Flags: review?(vporof)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Attachment #821091 -
Attachment is obsolete: true
Attachment #822907 -
Flags: review?(vporof)
Flags: needinfo?(nfitzgerald)
|
|
||
Updated•12 years ago
|
Attachment #822907 -
Flags: review?(vporof) → review+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 8•12 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•