Closed Bug 929868 Opened 6 years ago Closed 6 years ago

pretty print button is smaller than all other buttons

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 2 obsolete files)

Every other button is 32px wide, while the pretty print button is smaller.
Attached patch pp-button.patch (obsolete) — Splinter Review
Attachment #820798 - Flags: review?(vporof)
Need the patch from bug 917072 or else this patch will probably not apply. Doesn't technically "depend" on it though.
Depends on: 917072
Comment on attachment 820798 [details] [diff] [review]
pp-button.patch

Review of attachment 820798 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you attached the right patch.
Attachment #820798 - Flags: review?(vporof)
Attached patch pp-button.patch (obsolete) — Splinter Review
Woops!
Attachment #820798 - Attachment is obsolete: true
Attachment #821091 - Flags: review?(vporof)
Comment on attachment 821091 [details] [diff] [review]
pp-button.patch

Review of attachment 821091 [details] [diff] [review]:
-----------------------------------------------------------------

It'd be safer if you set a min-width to all toolbarbuttons in the #sources-toolbar.
Attachment #821091 - Flags: review?(vporof)
Planning to update this?
Flags: needinfo?(nfitzgerald)
Attached patch pp-button.patchSplinter Review
Attachment #821091 - Attachment is obsolete: true
Attachment #822907 - Flags: review?(vporof)
Flags: needinfo?(nfitzgerald)
Attachment #822907 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/da02805334ec
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.