Closed
Bug 929943
Opened 11 years ago
Closed 11 years ago
[Settings] Remove input type=range polyfill
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
(Keywords: perf, Whiteboard: [c= p=1 s=2013.11.08 u=])
Attachments
(1 file)
Now that bug 344618 has landed, we can remove our polyfill from the settings app.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 820928 [details] [review]
Github pull request
Kaze - Wondering if you wanted to review this one. I know you have a lot of patches in your queue so feel free to redirect to Evelyn/Arthur/Vivien if you wish. Thanks!
Attachment #820928 -
Flags: review?(kaze)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 820928 [details] [review]
Github pull request
Hi Arthur,
I noticed that this polyfill in the settings app started spitting out a lot of log messages. I removed the polyfill and verified that everything seemed to still work as intended. This should have a slight performance win and cleanup settings.js a bit. Please review if you have time. Thanks!
Attachment #820928 -
Flags: review?(kaze) → review?(arthur.chen)
|
|
Assignee | |
Comment 4•11 years ago
|
||
(Redirected review to Arhtur as Kaze is on PTO)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 820928 [details] [review]
Github pull request
r=me. Thank you for the clean up.
Attachment #820928 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Thanks for the review! Landed in master: https://github.com/mozilla-b2g/gaia/commit/1262e713ec2c3f97bde04fe368aba8fe1ddc65f2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2013.11.08 u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•