Closed Bug 930066 Opened 6 years ago Closed 6 years ago

Test coverage for cross-origin reflectors passed to CloneNonReflectors

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED DUPLICATE of bug 1027131

People

(Reporter: bholley, Assigned: gkrizsanits)

References

Details

(Keywords: sec-other)

Otherwise, we'll end up with the same problem we have with COWs in bugs like bug 926712, whereby content sends a cross-origin object to chrome and convinces chrome to toString it.

This should be a simple 1-line fix to CloneNonReflectorsWrite. Gabor, can you take this?
Gabor points out that we probably already do this by virtue of unwrapping the security wrapper with a CheckedUnwrap before hitting the reflector. So let's just morph this bug into something to make sure we have test coverage for that.
Summary: CloneNonReflectors should do a subsumes check when writing an Xrayable into the buffer → Test coverage for cross-origin reflectors passed to CloneNonReflectors
I add this test coverage in the last patch in bug 1027131.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1027131
Group: core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.