Closed Bug 930068 Opened 6 years ago Closed 6 years ago

GeckoView shouldn't require ACCOUNT access permission

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 27

People

(Reporter: blassey, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
Attachment #821082 - Flags: review?(mark.finkle)
Blocks: 930072
Blocks: 927831
Comment on attachment 821082 [details] [diff] [review]
dont_require_accounts.patch

>+            try {
>+                boolean syncIsSetup = SyncAccounts.syncAccountsExist(getAppContext());
>+                if (syncIsSetup) {
>+                    TabsAccessor.persistLocalTabs(getContentResolver(), getTabsInOrder());
>+                }
>+            } catch (SecurityException sex) {} // will fail without android.permission.GET_ACCOUNTS

sex -> se (let's keep it PG)

This is another one of those situations where we should think about a better long-term solution. Although if we eventually stop using/shipping Tabs/Tab Java classes with GeckoView, this will go away.
Attachment #821082 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/af16c2522e81
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.