930068 - GeckoView shouldn't require ACCOUNT access permission

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: dont_require_accounts.patch

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 821082 [details] [diff] [review]
dont_require_accounts.patch

>+            try {
>+                boolean syncIsSetup = SyncAccounts.syncAccountsExist(getAppContext());
>+                if (syncIsSetup) {
>+                    TabsAccessor.persistLocalTabs(getContentResolver(), getTabsInOrder());
>+                }
>+            } catch (SecurityException sex) {} // will fail without android.permission.GET_ACCOUNTS

sex -> se (let's keep it PG)

This is another one of those situations where we should think about a better long-term solution. Although if we eventually stop using/shipping Tabs/Tab Java classes with GeckoView, this will go away.

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/af16c2522e81