Closed Bug 930243 Opened 6 years ago Closed 5 years ago

Add a processType flag to chrome manifest directives

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: Unfocused, Assigned: billm)

References

Details

Attachments

(1 file)

A lot of components just don't work in child processes, or we only want them in the main process. We can filter these out at the chrome.manifest level via a flag. This should save us from bugs and memory usage.
Bill attached a patch in bug 930456 (attachment 8379893 [details] [diff] [review]) for this, based on his work in bug 966467.
Blocks: 930456
No longer blocks: fxdesktopbacklog
Moved over from bug 930456.
Assignee: bmcbride → wmccloskey
Attachment #8496261 - Flags: review?(benjamin)
Comment on attachment 8496261 [details] [diff] [review]
manifest-filtering

Maybe Nathan is less overloaded.
Attachment #8496261 - Flags: review?(benjamin) → review?(nfroyd)
Comment on attachment 8496261 [details] [diff] [review]
manifest-filtering

Review of attachment 8496261 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.
Attachment #8496261 - Flags: review?(nfroyd) → review+
Disabled the test on Android:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd1ab67d5b3c

The test failure was:
12:39:11 INFO - child: TEST-UNEXPECTED-FAIL | /mnt/sdcard/tests/xpcshell/xpcom/tests/unit/test_process_directives.js | [run_test : 8] /data/data/org.mozilla.fennec/data/process_directive.manifest does not exist 

I don't think we care about this on Android, so it seems easier to disable.
https://hg.mozilla.org/mozilla-central/rev/e5c5d33293aa
https://hg.mozilla.org/mozilla-central/rev/dd1ab67d5b3c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.