930243 - Add a processType flag to chrome manifest directives

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

A lot of components just don't work in child processes, or we only want them in the main process. We can filter these out at the chrome.manifest level via a flag. This should save us from bugs and memory usage.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Bill attached a patch in bug 930456 (attachment 8379893 [details] [diff] [review]) for this, based on his work in bug 966467.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: manifest-filtering

Moved over from bug 930456.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8496261 [details] [diff] [review]
manifest-filtering

Maybe Nathan is less overloaded.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8496261 [details] [diff] [review]
manifest-filtering

Review of attachment 8496261 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c5d33293aa

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Disabled the test on Android:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd1ab67d5b3c

The test failure was:
12:39:11 INFO - child: TEST-UNEXPECTED-FAIL | /mnt/sdcard/tests/xpcshell/xpcom/tests/unit/test_process_directives.js | [run_test : 8] /data/data/org.mozilla.fennec/data/process_directive.manifest does not exist 

I don't think we care about this on Android, so it seems easier to disable.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5c5d33293aa
https://hg.mozilla.org/mozilla-central/rev/dd1ab67d5b3c