930288 - Defect - Tab previews appear "zoomed" after using snapped view

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: Correct appearance of Tab Previews

If you move the Firefox Metro browser into "Snapped View", all the tab previews will look "zoomed in" even after going back into full view. When the user starts opening more tabs, those will appear correctly but the ones that were opened when the user moved the browser into snapped view will still appear zoomed. Reproduced this on several different machines and attached two screenshots.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Open several tabs by going to a few different websites
3) Once you have a few tabs opened, move the firefox metro browser into snapped view and then back into full view
4) Slide in the "Tab App Bar" and you'll notice that the tab previews look "zoomed"
5) Open a few new tabs and you'll notice that they will look correct but the original tabs will still look "zoomed in"

Current Behaviour:

- Moving the Firefox Metro browser into snapped view and then back into full view will change all of the current tab previews so they appear as "zoomed in"

Expected Behaviour:

- Moving the Firefox Metro browser between different views shouldn't change the tabs preview appearance

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-23-03-02-05-mozilla-central/

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Attachment: Incorrect Tab Preview appearance

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: 930288.patch

We were already updating the thumbnail after a metro_viewstate_changed, but there's a delay between changing the viewstate and the page finishing adjusting. The good old setTimeout fixed it. I'll see if I can find a better way to figure out the page is done adjusting. Will try resize event.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Resize worked much better. Also added a delay to give some sites a little extra time to adjust similar to what we do on load. This works great on sites like http://www.mozilla.org/en-US/about/ which resizes the images after a resize.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8339421 [details] [diff] [review]
Patch v1

Review of attachment 8339421 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.js
@@ +1324,5 @@
>        case "DOMWindowCreated":
>        case "SizeChanged":
>          this.updateViewport();
>          break;
> +      case "resize":

You should check if (aEvent.target == window), to filter out "resize" events coming from elements inside of content tabs.  Or you can listen for the "SizeChanged" event from ContentAreaObserver instead, which is basically a filtered version of the "resize" event.

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

Switched to using SizeChanged event. Waiting for open tree.

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/63f2a21f15fa

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63f2a21f15fa

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0

Verified on latest nightly (build ID: 20131209053402) using the scenario from comment 0 and got the expected results.