Closed Bug 93037 Opened 22 years ago Closed 21 years ago

Use ISO date format for attachment links (show_bug.cgi)

Categories

(Bugzilla :: Creating/Changing Bugs, defect, P1)

2.13

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: MatsPalmgren_bugz, Assigned: bbaetz)

References

()

Details

Attachments

(1 file, 1 obsolete file)

The Attachment links have a U.S. date format (MM/DD/YY).
Please use the ISO International Standard format which is YYYY-MM-DD
(already used elsewhere on the page.)

Thanks.
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
The patch needed a bit of hand-editing, as I've got some other changes in
that file, so apologies if it doesn't apply cleanly.
assigning bug to patch author, adding keywords
Assignee: justdave → gavins
Keywords: patch, review
Of course, is the DB the best place to do this?

Is the date_format() routine standard, or is it a MySQL-specific routine?

Would it be better to have a perl routine to do the formatting (here, and
elsewhere where the DB does it)?

If so, then I'll update the patch appropriately....

(and accepting)
Status: NEW → ASSIGNED
Component: Bugzilla → Creating/Changing Bugs
Product: Webtools → Bugzilla
Version: Bugzilla 2.13 → 2.10
correcting version field lost in product move
Version: 2.10 → 2.13
My patch was for the old attachment layout, so is a bit redundent.

But -- the new attachment table still has a non yyyy-mm-dd date format in the
modified column, which should be  fixed to be consistent.
http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/globals.pl#69

Bugzilla already uses Date::Format and Date::Parse... I'd think there could be
used to massage the date into ISO format.
Keywords: patch, review
I'm re-assigning this back to default owner/qa, as my patch was against the
pre-template attachment stuff, so is now out of date, and I'm not running 2.15,
so I can't update it.
Assignee: gavins → myk
Status: ASSIGNED → NEW
Attached patch patchSplinter Review
We don't need Date::Format - just add the appropriate punctuation.
Attachment #44797 - Attachment is obsolete: true
and taking
Assignee: myk → bbaetz
I think there should be a Perl routine to format dates consistently across all
Bugzilla GUIs, instead of hard-coding the formatting everywhere.

The format could then be easily tweaked in just one place, if desired.
I thought about that. I want to leave that until I get further into the postgres
stuff, and look at what date format it uses. Some of the selects select
date_Format(...), which won't work, and I'd do this as part of that change.
Status: NEW → ASSIGNED
CCing Myk, whose code this is.

Gerv
Comment on attachment 65966 [details] [diff] [review]
patch

r=gerv, but second review should come from Myk, as probably only he can say if
this has evil ramifications of which we are not aware.

Gerv
Attachment #65966 - Flags: review+
Comment on attachment 65966 [details] [diff] [review]
patch

patch looks good, r=myk
Attachment #65966 - Flags: review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.