93037 - Use ISO date format for attachment links (show_bug.cgi)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Mats Palmgren (inactive)]

The Attachment links have a U.S. date format (MM/DD/YY).
Please use the ISO International Standard format which is YYYY-MM-DD
(already used elsewhere on the page.)

Thanks.

Comment 1

[GavinS]

Attachment: patch to format attachment creation date as ISO

Comment 2

[GavinS]

The patch needed a bit of hand-editing, as I've got some other changes in
that file, so apologies if it doesn't apply cleanly.

Comment 3

[Dave Miller [:justdave]]

assigning bug to patch author, adding keywords

Comment 4

[GavinS]

Of course, is the DB the best place to do this?

Is the date_format() routine standard, or is it a MySQL-specific routine?

Would it be better to have a perl routine to do the formatting (here, and
elsewhere where the DB does it)?

If so, then I'll update the patch appropriately....

(and accepting)

Comment 5

[Dave Miller [:justdave]]

correcting version field lost in product move

Comment 6

[GavinS]

My patch was for the old attachment layout, so is a bit redundent.

But -- the new attachment table still has a non yyyy-mm-dd date format in the
modified column, which should be  fixed to be consistent.

Comment 7

[Jacob Steenhagen]

http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/globals.pl#69

Bugzilla already uses Date::Format and Date::Parse... I'd think there could be
used to massage the date into ISO format.

Comment 8

[GavinS]

I'm re-assigning this back to default owner/qa, as my patch was against the
pre-template attachment stuff, so is now out of date, and I'm not running 2.15,
so I can't update it.

Comment 9

[Bradley Baetz (:bbaetz)]

Attachment: patch

We don't need Date::Format - just add the appropriate punctuation.

Comment 10

[Bradley Baetz (:bbaetz)]

and taking

Comment 11

[GavinS]

I think there should be a Perl routine to format dates consistently across all
Bugzilla GUIs, instead of hard-coding the formatting everywhere.

The format could then be easily tweaked in just one place, if desired.

Comment 12

[Bradley Baetz (:bbaetz)]

I thought about that. I want to leave that until I get further into the postgres
stuff, and look at what date format it uses. Some of the selects select
date_Format(...), which won't work, and I'd do this as part of that change.

Comment 13

[Gervase Markham [:gerv]]

CCing Myk, whose code this is.

Gerv

Comment 14

[Gervase Markham [:gerv]]

Comment on attachment 65966 [details] [diff] [review]
patch

r=gerv, but second review should come from Myk, as probably only he can say if
this has evil ramifications of which we are not aware.

Gerv

Comment 15

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 65966 [details] [diff] [review]
patch

patch looks good, r=myk

Comment 16

[Bradley Baetz (:bbaetz)]

Checked in.