enable image visibility on b2g inside browser elements

RESOLVED FIXED in mozilla27

Status

()

Core
Layout: Images
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

27 Branch
mozilla27
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 821682 [details] [diff] [review]
enabrowseronly

The first step to enabling on b2g is to enable it inside browser elements on b2g, as opposed to apps and the system. This should be the most similar to the Fennec and desktop situation where we don't have things like system or apps.
Attachment #821682 - Flags: review?(matspal)
(Assignee)

Updated

5 years ago
Attachment #821682 - Flags: review?(khuey)
(Assignee)

Comment 1

5 years ago
It should be noted that currently we do not lock images on b2g, but Lock/Unlock as called from image loading content still determines which images we call StartDecoding on (which is worse than RequestDecode).
Comment on attachment 821682 [details] [diff] [review]
enabrowseronly

>+    if (docshell && !docshell->GetIsInBrowserElement()) {
>+      return true;

I'd slightly prefer "if (!docshell || ..." because we return true
for other error cases earlier.
Attachment #821682 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/a32f9f36d344
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(Assignee)

Updated

3 years ago
Depends on: 1213953
You need to log in before you can comment on or make changes to this bug.