Closed Bug 930535 Opened 6 years ago Closed 6 years ago

enable image visibility on b2g inside browser elements

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

27 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Attached patch enabrowseronlySplinter Review
The first step to enabling on b2g is to enable it inside browser elements on b2g, as opposed to apps and the system. This should be the most similar to the Fennec and desktop situation where we don't have things like system or apps.
Attachment #821682 - Flags: review?(matspal)
Attachment #821682 - Flags: review?(khuey)
It should be noted that currently we do not lock images on b2g, but Lock/Unlock as called from image loading content still determines which images we call StartDecoding on (which is worse than RequestDecode).
Comment on attachment 821682 [details] [diff] [review]
enabrowseronly

>+    if (docshell && !docshell->GetIsInBrowserElement()) {
>+      return true;

I'd slightly prefer "if (!docshell || ..." because we return true
for other error cases earlier.
Attachment #821682 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/a32f9f36d344
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 1213953
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.