930535 - enable image visibility on b2g inside browser elements

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: enabrowseronly

The first step to enabling on b2g is to enable it inside browser elements on b2g, as opposed to apps and the system. This should be the most similar to the Fennec and desktop situation where we don't have things like system or apps.

Comment 1

[Timothy Nikkel (:tnikkel)]

It should be noted that currently we do not lock images on b2g, but Lock/Unlock as called from image loading content still determines which images we call StartDecoding on (which is worse than RequestDecode).

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 821682 [details] [diff] [review]
enabrowseronly

>+    if (docshell && !docshell->GetIsInBrowserElement()) {
>+      return true;

I'd slightly prefer "if (!docshell || ..." because we return true
for other error cases earlier.

Comment 3

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a32f9f36d344

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a32f9f36d344