930583 - Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 821749 [details] [diff] [review]
Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h

Really odd to require to include various JS headers.

Comment 4

[(no longer active)]

(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 821749 [details] [diff] [review]
> Stop #including nsEventStateManager in nsWindowRoot.h and nsDocument.h
> 
> Really odd to require to include various JS headers.

I think those headers used to be indirectly included through nsEventStateManager.h.  This kind of thing is pretty common in includehell patches.  :-)

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15cf10638afe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15cf10638afe

Comment 7

[[e-mail]]

I got errors in HTMLAllCollection.obj and nsBindingManager.obj when linking xu.dll

HTMLAllCollection.obj : error LNK2019:  "public: class JSObject * __cdecl nsWrapperCache::GetWrapper(void)const " (?GetWrapper@nsWrapperCache@@QEBAPEAVJSObject@@XZ)

nsBindingManager.obj : error LNK2001:  "public: class JSObject
 * __cdecl nsWrapperCache::GetWrapper(void)const " (?GetWrapper@nsWrapperCache@@
QEBAPEAVJSObject@@XZ)

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to zhoubcfan from comment #7)
> I got errors in HTMLAllCollection.obj and nsBindingManager.obj when linking
> xu.dll
> 
> HTMLAllCollection.obj : error LNK2019:  "public: class JSObject * __cdecl
> nsWrapperCache::GetWrapper(void)const "
> (?GetWrapper@nsWrapperCache@@QEBAPEAVJSObject@@XZ)
> 
> nsBindingManager.obj : error LNK2001:  "public: class JSObject
>  * __cdecl nsWrapperCache::GetWrapper(void)const "
> (?GetWrapper@nsWrapperCache@@
> QEBAPEAVJSObject@@XZ)

I get the same error using GCC 4.5.1.

Comment 9

[Bill Gianopoulos [:WG9s]]

I filed Bug 931427 on this issue.