930589 - Reading List: list view does not reflect updated changes to reading list items

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Aaron Train [:aaronmt]]

Currently when one adds a reading list item to the reading list and attempts to rename it, it's a) treated like a non-existent bookmark and b) changes do not take affect.

When one edits the title of an item, the popup-prompt refers to 'Editing a Bookmark', and the toast that appears on confirmation reads: 'Bookmark Edited'. Changes do not take affect in the list-view.

On Aurora, changes *do* take affect in the list-view on update.

Also, why is the prompt still referring reading list items as bookmarks when we yanked them out of the bookmarks pane with the new about:home?

--
Nightly (10/24) & Aurora (10/24) | Samsung Galaxy SIV (Android 4.3)

Comment 1

[:Margaret Leibovic]

How does it work on release? Should we just hide the "Edit" context menu item for reading list items?

Comment 2

[Ian Barlow (:ibarlow)]

(In reply to :Margaret Leibovic from comment #1)
> How does it work on release? Should we just hide the "Edit" context menu
> item for reading list items?

Yes. I'm proposing we get rid of it in bug 931021

Comment 3

[:Margaret Leibovic]

Attachment: patch

This patch hides the "Edit" menuitem for reading list items.

Question for ibarlow: I know we're going to revamp our "Edit" menuitems in future bugs, but right now, should we also hide this menuitem for bookmarks in the top sites list? Right now we show it when a top site list item is a bookmark, but perhaps that is confusing.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/af76477c0003

Comment 5

[:Margaret Leibovic]

Comment on attachment 825493 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new about:home
User impact if declined: "Edit" context menu item is shown for reading list items, but it doesn't work properly. We don't want to support editing reading list items.
Testing completed (on m-c, etc.): just landed on fx-team
Risk to taking this patch (and alternatives if risky): low-risk, hide a context menu item
String or IDL/UUID changes made by this patch: none

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af76477c0003

Comment 7

[Aaron Train [:aaronmt]]

Summary is a bit unclear; but yes, confirmed removal of edit in the Reading List menu (via Nightly 11/05).

SoftVision, please update associated test-cases to reflect these changes.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eff86a8b5332
https://hg.mozilla.org/releases/mozilla-beta/rev/8a0c3982f7a1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8a0c3982f7a1

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Test Case added in moztrap:
https://moztrap.mozilla.org/manage/case/10773/