930653 - TopSites grid displays as 4/2 columns/rows

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect)

Description

[Sam Foster [:sfoster] (he/him)]

On some tablets, the TopSites grid will layout at 4 columns and 2 rows, when there is clearly vertical space for the preferred 3x3 layout.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Use translateY not scale on richgrids to avoid box dimension changes

Looks like this was a regression introduced when we added the scale(0.9) transition to the richgrids. As the scaling affects the actual dimensions of the element, when arrangeItems was called, depending on the timing, it could determine that only 2 rows would fit. 

In the patch I've used translateY to nudge down 25px - it gives us the equivalent bounce or rise effect as 0.9 scale. On the slower/lower-power devices you don't get a lot of frames but a subtle effect is still visible on my Dell Latitude 10.

Comment 2

[Sam Foster [:sfoster] (he/him)]

On fx-team: https://hg.mozilla.org/integration/fx-team/rev/aa6dec64e526

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/aa6dec64e526