Closed Bug 930672 Opened 11 years ago Closed 7 years ago

Change AssertNoObjectsToTrace to a boolean predicate

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Rather than asserting inside AssertNoObjectsToTrace, it would be nice to return a boolean to indicate if any JS things are being held.  This lets us use a regular assert, and also makes it easier to debug which class is actually failing the check, because you can see there is a failure inside CollectWhite(), which has access to the PtrInfo.
Blocks: CleanupCC
Attached patch change itSplinter Review
Naming suggestions welcome.  I still need to make sure it really works.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: