930758 - No back/forward swipe animation

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[(no longer active)]

I have been running with browser.snapshots.limits set to 5 for quite some time, and I don't get these swipe animations at all.  (I may be doing wrong, or this might be a bug.)

Comment 1

[(no longer active)]

(Please let me know what kinds of debugging information I can provide!)

Comment 2

[Steven Michaud [:smichaud] (Retired)]

In today's m-c nightly?  On which version of OS X?  Does the problem happen with a fresh profile?

Comment 3

[(no longer active)]

(In reply to comment #2)
> In today's m-c nightly?  On which version of OS X?  Does the problem happen
> with a fresh profile?

Today's nightly, on 10.8.5, with a fresh profile reproduces the problem.

Comment 4

[Stephen A Pohl [:spohl]]

(In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment #0)
> I have been running with browser.snapshots.limits set to 5

This may just be a typo, but please make sure that you have browser.snapshots.limit (no 's' after limit) set to 5 (or any other value > 0).

If this doesn't fix it, please verify that "Swipe between pages" is checked and set to "Scroll left or right with two fingers" in System Preferences > Trackpad > More Gestures. Does this fix it?

Comment 5

[(no longer active)]

(In reply to Stephen Pohl [:spohl] from comment #4)
> (In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment
> #0)
> > I have been running with browser.snapshots.limits set to 5
> 
> This may just be a typo, but please make sure that you have
> browser.snapshots.limit (no 's' after limit) set to 5 (or any other value >
> 0).

That was just a typo in my comment.  :-)

> If this doesn't fix it, please verify that "Swipe between pages" is checked
> and set to "Scroll left or right with two fingers" in System Preferences >
> Trackpad > More Gestures. Does this fix it?

OK, I figured it out at last.  If I set that setting to "Swipe with three fingers" then the swipe doesn't work in Firefox.  If I set that to "Swipe left or right with three fingers" then it works.

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment #5)
> If I set that setting to "Swipe with three fingers" then the swipe doesn't
> work in Firefox.

Are you saying that it only breaks in Firefox, or does Safari no longer have an animation either? For me, both Safari and Firefox work the same, but it'd be good to get confirmation from you. If both work the same, we can close this bug. Otherwise we'll want to look into it. Thanks!

Comment 7

[(no longer active)]

(In reply to Stephen Pohl [:spohl] from comment #6)
> (In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment
> #5)
> > If I set that setting to "Swipe with three fingers" then the swipe doesn't
> > work in Firefox.
> 
> Are you saying that it only breaks in Firefox, or does Safari no longer have
> an animation either? For me, both Safari and Firefox work the same, but it'd
> be good to get confirmation from you. If both work the same, we can close
> this bug. Otherwise we'll want to look into it. Thanks!

Hmm, that setting does indeed disable swipe animations in both Safari and Firefox.  But it also disables the page over scroll bounce effects in Firefox, while those effects are still there in Safari.

Comment 8

[Stephen A Pohl [:spohl]]

(In reply to :Ehsan Akhgari (needinfo? me!) [Away 10/29-11/6] from comment #7)
> But it also disables the page over scroll bounce effects in
> Firefox, while those effects are still there in Safari.

Right. This will be fixed once we have APZC on OSX. Right now, we rely on the history swipe animation logic to generate the bounce effect. Not ideal, but arguably better than not having anything at all...