930783 - please deploy browserid train-2013.10.23 to stage

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

sha: fdfdd553fa3c2a417c80d7457ced984a05fb9120

ChangeLog: https://github.com/mozilla/browserid/blob/train-2013.10.23/ChangeLog#L2-L11

Schedule: http://personatra.in/#2013.10.23

Comment 1

[Edwin Wong [:edwong]]

we're planning on pushing to stage on 10/28

Comment 2

[Karl Thiessen [:kthiessen, he/him]]

RPM now on r6:

/home/kthiessen/Library/github/mozilla/browserid_private/
rpmbuild/RPMS/x86_64/browserid-server-0.2013.10.23-1.el6_122101.x86_64.rpm

(with no line-break in the path)

Comment 3

[Gene Wood [:gene]]

Looks like this new build has a new config setting that convict is choking on :

@40000000527c1364182999ac UNCLE: Error: max_compute_processes: must be an integer
@40000000527c13641829a564     at Object.rv.validate (/opt/browserid/node_modules/convict/lib/convict.js:377:15)
@40000000527c13641829ad34     at Object.<anonymous> (/opt/browserid/lib/configuration.js:498:6)
@40000000527c13641829b11c     at Module._compile (module.js:449:26)
@40000000527c13641829b8ec     at Object.Module._extensions..js (module.js:467:10)
@40000000527c13641829c0bc     at Module.load (module.js:356:32)
@40000000527c13641829c4a4     at Function.Module._load (module.js:312:12)
@40000000527c1364182aab1c     at Module.require (module.js:362:17)
@40000000527c1364182ab2ec     at require (module.js:378:17)
@40000000527c1364182ab6d4     at Object.<anonymous> (/opt/browserid/lib/logging/transports/log-file.js:13:23)
@40000000527c1364182abea4     at Module._compile (module.js:449:26)

What is this new config setting? What kind of value should it have? Any other new config values?

Comment 4

[Sean McArthur [:seanmonstar]]

Ermahgawd, so sorry. Yes, there's a little bit adjustment to config. max_compute_process used to take `null` to mean use default, now it takes 0 to use the sane default. (Or you could just leave it out if you wanted, and the default will be using from lib/configuration.js, which is 0 already.

Also, all kpi_* config properties became kpi.*. So, they're now something like:

kpi: {
  backend_sample_rate: 0.2 // i dunno!
}

Comment 5

[Gene Wood [:gene]]

Ok, I've made these config changes here :

https://github.com/mozilla/identity-ops/commit/4a186cc79dd2a530ebd0fcf7f51aba977d0a176d

and will build new AMIs and staging stack

Comment 6

[Gene Wood [:gene]]

Stack 1108 has been built and staging DNS pointed to it.

Comment 7

[John Morrison [:jrgm]]

We haven't found a definitive resolution to the 'too busy' problem, and this is increasingly looking like it is a problem with AWS. So I put in a pull request to increase maximum_event_loop_lag to 100ms.

Gene: could you build a new stage stack with this change https://github.com/mozilla/identity-ops/pull/138
(and keeping the same rpm for train-2013.10.23).

Comment 8

[Gene Wood [:gene]]

I'll spin up a staging and 2 prod stacks of this by Wednesday morning. Apologies for the delay, I'm working on fxa

Comment 9

[Gene Wood [:gene]]

Stack 1211 is up and DNS has been pointed to it in stage.

Comment 10

[Karl Thiessen [:kthiessen, he/him]]

Old deployment -- belatedly marking VERIFIED.