Closed Bug 930845 Opened 7 years ago Closed 2 years ago

Remove unused "expander" binding and expander.xml

Categories

(Toolkit :: XUL Widgets, task)

x86
macOS
task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: WeirdAl, Assigned: 86ecce74)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [xbl-remove-unused][xbl-available])

Attachments

(1 file, 1 obsolete file)

As far as I can tell, no Firefox code uses it.  But it's been in the toolkit forever.  There's no documentation on MDN about it, either.  It might be the least supported widget (and that's saying something)...

Really, we should see if it's a candidate for removal as dead code.  Or we should support it with documentation and a mochitest.
Whiteboard: [xbl-remove-unused]
Whiteboard: [xbl-remove-unused] → [xbl-remove-unused][xbl-available]
Attachment #8931855 - Flags: review?(enndeakin)
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED
Comment on attachment 8931855 [details] [diff] [review]
Removed expander binding and expander.xml

You should also remove expander.css
Comment on attachment 8931855 [details] [diff] [review]
Removed expander binding and expander.xml

See above comment.
Attachment #8931855 - Flags: review?(enndeakin) → review-
86ecce74, are you still working on this?
Flags: needinfo?(86ecce74)
Attachment #8931855 - Attachment is obsolete: true
Flags: needinfo?(86ecce74)
Attachment #8940288 - Flags: review?(enndeakin)
Attachment #8940288 - Flags: review?(enndeakin) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be780bf2c08a
Removed expander binding, expander.css and expander.xml; r=enn
https://hg.mozilla.org/mozilla-central/rev/be780bf2c08a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Type: defect → task
You need to log in before you can comment on or make changes to this bug.