Remove unused "expander" binding and expander.xml

RESOLVED FIXED in Firefox 59

Status

()

RESOLVED FIXED
5 years ago
11 months ago

People

(Reporter: WeirdAl, Assigned: 86ecce74)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla59
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [xbl-remove-unused][xbl-available], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
As far as I can tell, no Firefox code uses it.  But it's been in the toolkit forever.  There's no documentation on MDN about it, either.  It might be the least supported widget (and that's saying something)...

Really, we should see if it's a candidate for removal as dead code.  Or we should support it with documentation and a mochitest.
I still don't see any usage either, so I believe it can be removed:

https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#1159
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/expander.xml
https://searchfox.org/mozilla-central/search?q=expander
Blocks: 1397874, 1387013
Summary: XUL expander widget needs a test - or needs removal → Remove unused "expander" binding and expander.xml
Whiteboard: [xbl-remove-unused]
Whiteboard: [xbl-remove-unused] → [xbl-remove-unused][xbl-available]
(Assignee)

Comment 2

a year ago
Created attachment 8931855 [details] [diff] [review]
Removed expander binding and expander.xml
Attachment #8931855 - Flags: review?(enndeakin)
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED

Comment 3

a year ago
Comment on attachment 8931855 [details] [diff] [review]
Removed expander binding and expander.xml

You should also remove expander.css

Comment 4

11 months ago
Comment on attachment 8931855 [details] [diff] [review]
Removed expander binding and expander.xml

See above comment.
Attachment #8931855 - Flags: review?(enndeakin) → review-
86ecce74, are you still working on this?
Flags: needinfo?(86ecce74)
(Assignee)

Comment 6

11 months ago
Created attachment 8940288 [details] [diff] [review]
Removed expander binding and expander.xml
Attachment #8931855 - Attachment is obsolete: true
Flags: needinfo?(86ecce74)

Updated

11 months ago
Attachment #8940288 - Flags: review?(enndeakin)

Updated

11 months ago
Attachment #8940288 - Flags: review?(enndeakin) → review+

Comment 7

11 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be780bf2c08a
Removed expander binding, expander.css and expander.xml; r=enn

Comment 8

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be780bf2c08a
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.