930860 - Move some methods in WidgetEvent to WidgetMouseEvent

Status: RESOLVED FIXED

(Core :: Widget, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Move IsLeftClickEvent() and IsContextMenuKeyEvent() from WidgetEvent to WidgetMouseEvent(Base)

From smaug's request, I wrote this.

However, at reading around the callers, this patch just makes the code complicated.

Indeed, the WidgetEvent becomes simple, but I don't feel this is good change.

Requesting to review to both roc and smaug.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Well, if IsLeftClickEvent and IsContextMenuKeyEvent are in the WidgetEvent, so should
IsAlt & co. Or if those aren't there, then IsLeftClickEvent and IsContextMenuKeyEvent should be in
the right class, not in the base class.
So basically, whatever we do, let's do it consistently :)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 822264 [details] [diff] [review]
Move IsLeftClickEvent() and IsContextMenuKeyEvent() from WidgetEvent to WidgetMouseEvent(Base)

Review of attachment 822264 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should do this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 822264 [details] [diff] [review]
Move IsLeftClickEvent() and IsContextMenuKeyEvent() from WidgetEvent to WidgetMouseEvent(Base)

Might be useful to have IsFooBarEvent() in the base event and if that returns
true event->AsFooBarEvent()->DoSomething would be ok.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d18faa1a97

(In reply to Olli Pettay [:smaug] from comment #4)
> Might be useful to have IsFooBarEvent() in the base event and if that returns
> true event->AsFooBarEvent()->DoSomething would be ok.

Do you think that IsFooBarEvent() returns true even if the eventStructType doesn't exactly match? I.e., the implementation becomes |return AsFooBarEvent() != nullptr;|? If so, it's same as |event->AsFooBarEvent() && event->AsFooBarEvent()->DoSomething()|.

If you think that IsForBarEvent() returns true only when eventStructType exactly match, I love them. See this post:
https://groups.google.com/d/msg/mozilla.dev.platform/cHg_ExqEC_U/adfrnWQUB7cJ

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

IsFooBarEvent() should return true it the event is FooBar or extends FooBar.
That is what DOM code does with IsElement() for example.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #6)
> IsFooBarEvent() should return true it the event is FooBar or extends FooBar.
> That is what DOM code does with IsElement() for example.

Hmm, then, I don't think that we need to implement them because they just do AsFooBarEvent() != nullptr...

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b9d18faa1a97