Clean up and modularize SessionStore code a little more

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Session Restore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

4 years ago
Based off of bug 930202 and bug 919835 we can do some cleanup and move TabState as well as TabAttributes to their own JSMs.
(Assignee)

Comment 1

4 years ago
Created attachment 822172 [details] [diff] [review]
Move TabState and TabAttributes to their own JSMs
Attachment #822172 - Flags: review?(wmccloskey)
(Assignee)

Comment 2

4 years ago
Created attachment 822189 [details] [diff] [review]
Move TabState and TabAttributes to their own JSMs, v2

Small addition.
Attachment #822172 - Attachment is obsolete: true
Attachment #822172 - Flags: review?(wmccloskey)
Attachment #822189 - Flags: review?(wmccloskey)
(Assignee)

Comment 3

4 years ago
Created attachment 822199 [details] [diff] [review]
Introduce Utils.jsm

This patch introduces a Utils.jsm that contains makeURI() and hasRootDomain(). We will need the latter for upcoming work.
Attachment #822199 - Flags: review?(wmccloskey)
(Assignee)

Updated

4 years ago
Summary: Move TabState and TabAttributes to their own JSMs → Clean up and modularize SessionStore code a little more
(Assignee)

Comment 4

4 years ago
Created attachment 822209 [details] [diff] [review]
Introduce Utils.jsm, v2

Oops, little fix.
Attachment #822199 - Attachment is obsolete: true
Attachment #822199 - Flags: review?(wmccloskey)
Attachment #822209 - Flags: review?(wmccloskey)
(Assignee)

Comment 5

4 years ago
Created attachment 822211 [details] [diff] [review]
Rename _SessionFile to SessionFile

Ok, while I'm at it... It always bugged me that we called it _SessionFile. Let's rename that to SessionFile (remove the underscore) so that it fits nicely with all our other modules.
Attachment #822211 - Flags: review?(wmccloskey)
(Assignee)

Comment 6

4 years ago
That should be it. All those patches don't change how stuff works, they just move code around.
(Assignee)

Comment 7

4 years ago
Created attachment 822217 [details] [diff] [review]
Rename _SessionFile to SessionFile, v2

Sorry, sed fixed a couple of line endings that I didn't indent to include in the patch.
Attachment #822211 - Attachment is obsolete: true
Attachment #822211 - Flags: review?(wmccloskey)
Attachment #822217 - Flags: review?(wmccloskey)
(Assignee)

Updated

4 years ago
Blocks: 930967
Comment on attachment 822189 [details] [diff] [review]
Move TabState and TabAttributes to their own JSMs, v2

Review of attachment 822189 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. I'm going to try to land bug 919835 after the merge to aurora.
Attachment #822189 - Flags: review?(wmccloskey) → review+
Attachment #822217 - Flags: review?(wmccloskey) → review+
Attachment #822209 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/56e059ba321a
https://hg.mozilla.org/mozilla-central/rev/04983771c47b
https://hg.mozilla.org/mozilla-central/rev/be5e71554114
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
(Assignee)

Updated

4 years ago
Depends on: 936911
You need to log in before you can comment on or make changes to this bug.