930916 - Add a function to get the robocop painted surface as a dataURI so it can be dumped to the tbpl log

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

I found this kind of useful while trying to debug 911152 and I'd like to get it into the tree before I forget.

Comment 1

[(not currently active) Ted Mielczarek]

Can we not hardcode the base64 behavior in here? bug 749421 is getting closer to production, which would let you just write the file to a specific directory and have it accessible via HTTP after the build is done. See attachment 801885 [details] [diff] [review] for the changes we're making to the Mochitest screenshot-on-timeout code to work with this.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

We could definitely add another function to PaintedSurface to save it to a file after those other bugs land. Or maybe this patch isn't needed at all if there's some other way to get a screenshot of the content area that works on Fennec.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 822205 [details] [diff] [review]
Patch

Review of attachment 822205 [details] [diff] [review]:
-----------------------------------------------------------------

I often find myself in need of a content area screenshot when debugging the PixelTests, so I like to see this. 

Ted makes a good point about the changing screenshot landscape. I'm happy to wait for 749421 and do this work just once, but if you want to land this patch now, I think that's ok too.  

I thought we might use something like https://tbpl.mozilla.org/?tree=Try&rev=906670ff9bbf as a temporary middle-ground -- dumping the existing pixels.map the same way we handle robocop screenshots. But we need a format conversion to make that work; I'm sure it can be done in the harness, but it makes more sense to do that in PaintedSurface.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I decided to land this for now, we can update it as needed when the other stuff lands.

https://hg.mozilla.org/integration/fx-team/rev/373338c73faf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/373338c73faf