Add a function to get the robocop painted surface as a dataURI so it can be dumped to the tbpl log

RESOLVED FIXED in mozilla28

Status

Testing
Mochitest
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla28
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 822205 [details] [diff] [review]
Patch

I found this kind of useful while trying to debug 911152 and I'd like to get it into the tree before I forget.
Attachment #822205 - Flags: review?(gbrown)
OS: Mac OS X → Android
Hardware: x86 → All
Can we not hardcode the base64 behavior in here? bug 749421 is getting closer to production, which would let you just write the file to a specific directory and have it accessible via HTTP after the build is done. See attachment 801885 [details] [diff] [review] for the changes we're making to the Mochitest screenshot-on-timeout code to work with this.
We could definitely add another function to PaintedSurface to save it to a file after those other bugs land. Or maybe this patch isn't needed at all if there's some other way to get a screenshot of the content area that works on Fennec.
Comment on attachment 822205 [details] [diff] [review]
Patch

Review of attachment 822205 [details] [diff] [review]:
-----------------------------------------------------------------

I often find myself in need of a content area screenshot when debugging the PixelTests, so I like to see this. 

Ted makes a good point about the changing screenshot landscape. I'm happy to wait for 749421 and do this work just once, but if you want to land this patch now, I think that's ok too.  

I thought we might use something like https://tbpl.mozilla.org/?tree=Try&rev=906670ff9bbf as a temporary middle-ground -- dumping the existing pixels.map the same way we handle robocop screenshots. But we need a format conversion to make that work; I'm sure it can be done in the harness, but it makes more sense to do that in PaintedSurface.
Attachment #822205 - Flags: review?(gbrown) → review+
I decided to land this for now, we can update it as needed when the other stuff lands.

https://hg.mozilla.org/integration/fx-team/rev/373338c73faf
Assignee: nobody → bugmail.mozilla
https://hg.mozilla.org/mozilla-central/rev/373338c73faf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.