Create a System app region for "app install confirmation"

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P4
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zac, Assigned: bsilverberg)

Tracking

unspecified
Other
Linux

Firefox Tracking Flags

(b2g-v1.2 affected)

Details

(Whiteboard: [gaia-ui-test][mentor=zac][lang=py])

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
A few tests use this confirmation prompt, eg test_homescreen_delete_app, test_homescreen_launch_app.

We can make all these tests use the single confirmation region.

Comment 1

4 years ago
Hello, this is the first thing I will be working on for Mozilla (if I get to start). I know only python and have no prior experience in open-source projects. Can I be of any help?
(Reporter)

Comment 2

4 years ago
Yes you sure can Aman!

What we want is for a "App install confirmation" class in "tests/python/gaia-ui-tests/gaiatest/apps/system/region" folder.

It will be very similar to this in the homepage app.
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/confirm_dialog.py

Once you've created that you'll need to search through all of the tests to find the where the region can be used and update the tests and app objects to use it.

If you flick through our existing tests you'll be able to see the style of code that we use.

If you have any more questions you can email me or find us in the #mozwebqa IRC channel.
Assignee: nobody → aman.abhishek.01
(Reporter)

Comment 3

4 years ago
Reassigning to bitgeeky :)
Assignee: aman.abhishek.01 → mozpankaj1994
Created attachment 829711 [details]
Raw idea of the new class ConfirmInstall in confirm_install.py

:zac just a raw idea of the new class ConfirmInstall in confirm_install.py , also please let me know some test where 
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/confirm_dialog.py 
is in use , so that i can get a better understanding of how to make changes in tests and use the new ConfirmInstall class.
Attachment #829711 - Flags: feedback?(zcampbell)
Flags: needinfo?(zcampbell)
(Reporter)

Comment 5

4 years ago
Comment on attachment 829711 [details]
Raw idea of the new class ConfirmInstall in confirm_install.py

Hey bitgeeky, that's perfect!

If you search for 'app-install-install-button' in the /gaia-ui-tests/ folder then you'll be able to search backwards and find the tests and app objects that are using it.

Updated

4 years ago
Status: NEW → ASSIGNED
Created attachment 830479 [details] [diff] [review]
930992.patch

:zac please have a look at this attachment , and suggest changes if any :)
Attachment #830479 - Flags: feedback?(zcampbell)
(Reporter)

Comment 7

4 years ago
Comment on attachment 830479 [details] [diff] [review]
930992.patch

Review of attachment 830479 [details] [diff] [review]:
-----------------------------------------------------------------

bitgeeky, this looks great.
Now you need to file it as a pull request so that we can run it on devices and run it on Travis.

Almost ready to merge :)
Attachment #830479 - Flags: feedback?(zcampbell) → feedback+
(Reporter)

Updated

4 years ago
Attachment #829711 - Flags: feedback?(zcampbell)
Created attachment 830851 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13625

Pointer to Github pull-request
Attachment #830851 - Flags: review?(zcampbell)
(Reporter)

Comment 9

4 years ago
Comment on attachment 830851 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13625

Nice pull, it works perfectly both on a device and on desktopb2g!
Attachment #830851 - Flags: review?(zcampbell) → review+
(Reporter)

Comment 10

4 years ago
Merged:
https://github.com/mozilla-b2g/gaia/commit/c547e3890114629b44b1bcddfabb85e4f37e6424

Let's bring this into v1.2 too.
It looks to be clean but marking ? just as not 100% sure.
status-b2g-v1.2: --- → ?
Flags: needinfo?(zcampbell)
thanks :zac :)
(Assignee)

Comment 12

4 years ago
Taking for v1.2 uplift
Assignee: mozpankaj1994 → bob.silverberg
(Assignee)

Comment 13

4 years ago
Created attachment 831259 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13646

Pointer to Github pull-request
(Assignee)

Comment 14

4 years ago
Comment on attachment 831259 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13646

Uplift for v1.2
Attachment #831259 - Flags: review?(trifandreialin)
Attachment #831259 - Flags: review?(moz.teodosia)
Attachment #831259 - Flags: review?(florin.strugariu)
Attachment #831259 - Flags: review?(andrei.hutusoru)
(Assignee)

Updated

4 years ago
status-b2g-v1.2: ? → affected

Updated

4 years ago
Attachment #831259 - Flags: review?(moz.teodosia) → review-
Attachment #831259 - Flags: review?(florin.strugariu) → review+

Updated

4 years ago
Blocks: 938550

Updated

4 years ago
Attachment #831259 - Flags: review?(trifandreialin)
Attachment #831259 - Flags: review?(andrei.hutusoru)
Attachment #831259 - Flags: review-
Attachment #831259 - Flags: review+

Comment 15

4 years ago
Merged in v1.2:
https://github.com/bobsilverberg/gaia/commit/3cfe74ff456cff5696ce53158355a466fe263e36
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.