Closed
Bug 931053
Opened 12 years ago
Closed 12 years ago
don't build Mac host tools when --disable-crashreporter
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: froydnj, Unassigned)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.71 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We already do the equivalent for Linux.
|
Reporter | |
Comment 1•12 years ago
|
||
Just like the Linux version.
Attachment #822388 -
Flags: review?(ted)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 822388 [details] [diff] [review]
don't build Mac host tools if --disable-crashreporter
Review of attachment 822388 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/crashreporter/google-breakpad/src/common/mac/moz.build
@@ +17,5 @@
> 'string_utilities.cc',
> ]
>
> +if CONFIG['MOZ_CRASHREPORTER']:
> + HOST_CPPSRCS += CPP_SOURCES
n.b. bug 929905 made these into HOST_SOURCES, SOURCES.
Attachment #822388 -
Flags: review?(ted) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•