931076 - [B2G] [1.2] [l10n][Settings] Greek: “Improve Firefox OS” banner is truncated in Greek

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Allen Maxwell]

Attachment: 2013-10-25-09-31-11.png

Description:
With Greek language selected “Improve Firefox OS” is truncated in settings/Improve Firefox OS


Repro Steps:
1) Updated to v1.2 Buri Build ID:  20131025004000 Commercial RIL
2) Set language to Greek
3) Go to settings/Improve Firefox OS
4) Observe Banner

Actual:
Banner text is truncated

Expected:
Text needs to be visible and not truncated

Environmental Variables:
Device: Buri v1.2 Commercial RIL
Build ID: 20131025004000
Gecko: 5eabd267ef04
Gaia: 606517ceafe0950c2b89822d5f13353743334f2c
Version #: 26.0a2
Base Image: 20131015
RIL Version: 01.02.00.019.082

Comment 1

[Eric Pang [:epang] UX]

We can update the header string to "Feedback". Thanks!

Comment 2

[Alfredos-Panagiotis Damkalis [:fredy]]

Changing the string to "Feedback" will fix this bug but will change also the string in the settings list and will remove tha brand name that now exists in this string.

Is this ok?

Comment 3

[Eric Pang [:epang] UX]

(In reply to Alfredos-Panagiotis Damkalis [:fredy] from comment #2)
> Changing the string to "Feedback" will fix this bug but will change also the
> string in the settings list and will remove tha brand name that now exists
> in this string.
> 
> Is this ok?

Yes this should be fine, but is only for Greek.  Feedback is more accurate on what the screen is doing anyways :).

Comment 4

[Alfredos-Panagiotis Damkalis [:fredy]]

Ok I'll create a patch with this change and I will talk with Alexandros to land it.

Thank you!

Comment 5

[Francesco Lodolo [:flod]]

:fredy
Can we close this?

Note that now we have two separate strings (button/title)
https://hg.mozilla.org/gaia-l10n/en-US/file/960a796879dd/apps/settings/settings.properties#l1091

Comment 6

[alco]

:flod
changed the title string to display only the brandname
https://hg.mozilla.org/releases/gaia-l10n/v1_3/el/rev/ccdd7f7b8615