Closed Bug 931125 Opened 6 years ago Closed 6 years ago
[Gallery] [Camera] We have to take into account the screen pixel ratio when checking if the thumbnail fills the screen
In the Gallery and the Camera app we check if the EXIF thumbnail is large enough to fill the device screen. We only make use of window.innerWidth and window.innerHeight but we don't not taking into account the device pixel ratio (window.devicePixelRatio). Thumbnails will be stretched in HD devices and the rendered images will look blurry. Below the correct way to calculate the minimum size for a thumbnail: var thumbnailMinimumWidth = window.innerWidth * window.devicePixelRatio; var thumbnailMinimumHeight = window.innerHeight * window.devicePixelRatio;
Required for bug 928614
blocking-b2g: hd? → hd+
Diego, will you also take this one?
Assignee: nobody → dmarcos
Yes. I got this one
Comment on attachment 829393 [details] [review] Pull Request Looks good to me, if you fix the error in the metadata parser file. I can't do a full review since this is a PR against one of your own branches rather than against master, but from what I can see the code looks fine.
Attachment #829393 - Flags: review?(dflanagan) → review+
Landed on master: https://github.com/mozilla-b2g/gaia/commit/ce41989a456a60ffdcccb9f19033ccce26ac99be Landed on v1.2: https://github.com/mozilla-b2g/gaia/commit/ee1fdceb8c5cfdde190e41a0b22ed3d2823f4c65 Landed on v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/de91d544cfe9b005240ef0be2600f8a6f520e0f0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.