Closed
Bug 931146
Opened 11 years ago
Closed 11 years ago
Frame metrics mMayHaveTouchListeners never gets set for tab content
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox28 | --- | fixed |
People
(Reporter: jimm, Assigned: jimm)
References
Details
(Whiteboard: [block28][qa-])
Attachments
(4 files)
3.55 KB,
text/html
|
Details | |
16.67 KB,
text/html
|
Details | |
1.63 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
4.77 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
We set this flag for the root ViewportFrame [1] but when we record frame metrics for a nsDisplayScrollLayer we fail to check to see if the document has listeners. In metrofx, nsDisplayScrollLayer contains the browser tab. [1] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#1251 [2] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#3549
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → jmathies
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #822477 -
Flags: review?(tnikkel)
Assignee | ||
Updated•11 years ago
|
Comment 4•11 years ago
|
||
Comment on attachment 822477 [details] [diff] [review] proposed fix v.1 Seems fine, although I don't know what mMayHaveTouchListeners is used for exactly. Could you just move this code into RecordFrameMetrics though? No need to duplicate it.
Attachment #822477 -
Flags: review?(tnikkel)
Attachment #822477 -
Flags: review?(bugmail.mozilla)
Attachment #822477 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #822477 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #822945 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #822945 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Updated•11 years ago
|
Whiteboard: [blocker]
Updated•11 years ago
|
Whiteboard: [blocker] → [block28]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4533ba7b957f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 8•10 years ago
|
||
No, using the test case requires simulating touch inputs which we are not really set up to do in a cross-platform way.
You need to log in
before you can comment on or make changes to this bug.
Description
•