Closed Bug 931146 Opened 11 years ago Closed 11 years ago

Frame metrics mMayHaveTouchListeners never gets set for tab content

Categories

(Core :: Layout, defect)

26 Branch
x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [block28][qa-])

Attachments

(4 files)

We set this flag for the root ViewportFrame [1] but when we record frame metrics for a nsDisplayScrollLayer we fail to check to see if the document has listeners. In metrofx, nsDisplayScrollLayer contains the browser tab.

[1] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#1251
[2] http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.cpp#3549
Attached file test case
Assignee: nobody → jmathies
Attached patch proposed fix v.1Splinter Review
Attachment #822477 - Flags: review?(tnikkel)
Blocks: metro-apzc
No longer blocks: 918273
Comment on attachment 822477 [details] [diff] [review]
proposed fix v.1

Seems fine, although I don't know what mMayHaveTouchListeners is used for exactly.

Could you just move this code into RecordFrameMetrics though? No need to duplicate it.
Attachment #822477 - Flags: review?(tnikkel)
Attachment #822477 - Flags: review?(bugmail.mozilla)
Attachment #822477 - Flags: review+
Attachment #822477 - Flags: review?(bugmail.mozilla)
Attached patch proposed fix v.2Splinter Review
Attachment #822945 - Flags: review?(bugmail.mozilla)
Attachment #822945 - Flags: review?(bugmail.mozilla) → review+
Whiteboard: [blocker]
Whiteboard: [blocker] → [block28]
https://hg.mozilla.org/mozilla-central/rev/4533ba7b957f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Flags: in-testsuite?
Whiteboard: [block28] → [block28][qa-]
This bug has a testcase. Did that get checked in?
No, using the test case requires simulating touch inputs which we are not really set up to do in a cross-platform way.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: