Closed Bug 931171 Opened 10 years ago Closed 10 years ago

Clear tracking-fennec:? flag from bugs with a last modified before 2013-09-01


( :: Infrastructure, defect)

Not set





(Reporter: kbrosnan, Assigned: nmaul)



(1 file, 1 obsolete file)

I've been keeping the tracking-fennec:? nominations clear of resolved bugs for the last month or so. However there is a ~1125 bug backlog. Rather than me manually clearing the flag and creating a ton of bugmail. Would it be possible to remove the tracking-fennec:? flag from any bug that was last touched before 2013-09-01 by modifying the DB?

tracking fennec:+ and tracking-fennec:+# should not be touched.

I am going off sorted by last modified.
Poke on this request?
Flags: needinfo?(glob)
Flags: needinfo?(dkl)
i'll work on the script required to do this.
Assignee: nobody → glob
Flags: needinfo?(glob)
Flags: needinfo?(dkl)
Attached patch 931171_1.patch (obsolete) — Splinter Review
adds a script for bulk tracking-flags updating.

sample invocation:

./extensions/TrackingFlags/bin/ --flag cf_blocking_fennec --modified_before 2013-09-01 --value '?' --update_db
Attachment #826805 - Flags: review?(dkl)
[dkl@bzweb 931171]$ patch -p0 < 931171-826805.patch 
patching file extensions/TrackingFlags/
patch: **** malformed patch at line 35: @@ -362,24 +372,31 @@

Will continue by manually applying so I can continue the review.

Just to be clear as I review this, should this be only affecting RESOLVED bugs and leave bugs that are currently open alone?
Flags: needinfo?(kbrosnan)
The open bugs are triaged by on a weekly basis by the Fx Android team.

The oldest last touched for that query is 2013-10-22 so it should not matter if it is all bugs or open bugs.
Flags: needinfo?(kbrosnan)
Comment on attachment 826805 [details] [diff] [review]

Review of attachment 826805 [details] [diff] [review]:

r- due to patch needs to be regenerated.

Non-related error when editing multiple bugs and ->can_set_value is called on a value without a specific group. 
Here is the fix below to be rolled into your commit.

=== modified file 'extensions/TrackingFlags/lib/'
--- extensions/TrackingFlags/lib/	2013-10-16 14:26:31 +0000
+++ extensions/TrackingFlags/lib/	2013-11-06 23:18:38 +0000
@@ -389,7 +389,9 @@
-    return $new_value_obj && $user->in_group($new_value_obj->setter_group->name)
+    return $new_value_obj
+           && $new_value_obj->setter_group
+           && $user->in_group($new_value_obj->setter_group->name)
            ? 1
            : 0;

Attachment #826805 - Flags: review?(dkl) → review-
Attached patch 931171_2.patchSplinter Review
Attachment #828684 - Flags: review?(glob)
Attachment #828684 - Flags: review?(glob) → review?(dkl)
Comment on attachment 828684 [details] [diff] [review]

Review of attachment 828684 [details] [diff] [review]:

Attachment #828684 - Flags: review?(dkl) → review+
Attachment #826805 - Attachment is obsolete: true
Committing to: bzr+ssh://
modified extensions/TrackingFlags/
added extensions/TrackingFlags/bin/
modified extensions/TrackingFlags/lib/
Committed revision 9140.

once this has been pushed, we can finally clear those flags!
Poke on pushing the right buttons?
Looks like this made it to BMO on anything else needed to progress on this?
Flags: needinfo?(glob)
oops, sorry that this was lost -

can the following please be executed against the bmo production instance:

./extensions/TrackingFlags/bin/ --flag cf_blocking_fennec --modified_before 2013-09-01 --value '?' --update_db

Assignee: glob → server-ops-webops
Component: Administration → WebOps: Bugzilla
Flags: needinfo?(glob)
Product: → Infrastructure & Operations
QA Contact: nmaul
Version: Production → other
I started this but had some internet trouble and my session got disconnected... when I got back in and tried it again, there were "no matching bugs found", so I guess it actually finished.

Closing this out... if anything more needs done, please re-open and let us know. Thanks!
Assignee: server-ops-webops → nmaul
Closed: 10 years ago
Resolution: --- → FIXED
Component: WebOps: Bugzilla → Infrastructure
Product: Infrastructure & Operations →
You need to log in before you can comment on or make changes to this bug.