931171 - Clear tracking-fennec:? flag from bugs with a last modified before 2013-09-01

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Infrastructure, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

I've been keeping the tracking-fennec:? nominations clear of resolved bugs for the last month or so. However there is a ~1125 bug backlog. Rather than me manually clearing the flag and creating a ton of bugmail. Would it be possible to remove the tracking-fennec:? flag from any bug that was last touched before 2013-09-01 by modifying the DB?

tracking fennec:+ and tracking-fennec:+# should not be touched.

I am going off https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20cf_blocking_fennec%3A%3F sorted by last modified.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Poke on this request?

Comment 2

[:glob ✱]

i'll work on the script required to do this.

Comment 3

[:glob ✱]

Attachment: 931171_1.patch

adds a script for bulk tracking-flags updating.

sample invocation:

./extensions/TrackingFlags/bin/bulk_flag_clear.pl --flag cf_blocking_fennec --modified_before 2013-09-01 --value '?' --update_db

Comment 4

[David Lawrence [:dkl]]

[dkl@bzweb 931171]$ patch -p0 < 931171-826805.patch 
patching file extensions/TrackingFlags/Extension.pm
patch: **** malformed patch at line 35: @@ -362,24 +372,31 @@

Will continue by manually applying so I can continue the review.

dkl

Comment 5

[David Lawrence [:dkl]]

Just to be clear as I review this, should this be only affecting RESOLVED bugs and leave bugs that are currently open alone?

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

The open bugs are triaged by https://bugzilla.mozilla.org/buglist.cgi?order=Bug%20Number&field0-0-0=cf_blocking_fennec&resolution=---&query_format=advanced&type0-0-0=equals&value0-0-0=%3F on a weekly basis by the Fx Android team.

The oldest last touched for that query is 2013-10-22 so it should not matter if it is all bugs or open bugs.

Comment 11

[David Lawrence [:dkl]]

Comment on attachment 826805 [details] [diff] [review]
931171_1.patch

Review of attachment 826805 [details] [diff] [review]:
-----------------------------------------------------------------

r- due to patch needs to be regenerated.

Non-related error when editing multiple bugs and ->can_set_value is called on a value without a specific group. 
Here is the fix below to be rolled into your commit.

=== modified file 'extensions/TrackingFlags/lib/Flag.pm'
--- extensions/TrackingFlags/lib/Flag.pm	2013-10-16 14:26:31 +0000
+++ extensions/TrackingFlags/lib/Flag.pm	2013-11-06 23:18:38 +0000
@@ -389,7 +389,9 @@
             last;
         }
     }
-    return $new_value_obj && $user->in_group($new_value_obj->setter_group->name)
+    return $new_value_obj
+           && $new_value_obj->setter_group
+           && $user->in_group($new_value_obj->setter_group->name)
            ? 1
            : 0;
 }

Thanks
dkl

Comment 12

[:glob ✱]

Attachment: 931171_2.patch

Comment 13

[David Lawrence [:dkl]]

Comment on attachment 828684 [details] [diff] [review]
931171_2.patch

Review of attachment 828684 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 14

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
added extensions/TrackingFlags/bin/bulk_flag_clear.pl
modified extensions/TrackingFlags/lib/Flag.pm
Committed revision 9140.

once this has been pushed, we can finally clear those flags!

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

Poke on pushing the right buttons?

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

Looks like this made it to BMO on http://globau.wordpress.com/2013/11/14/happy-bmo-push-day-73/ anything else needed to progress on this?

Comment 17

[:glob ✱]

oops, sorry that this was lost -

can the following please be executed against the bmo production instance:

./extensions/TrackingFlags/bin/bulk_flag_clear.pl --flag cf_blocking_fennec --modified_before 2013-09-01 --value '?' --update_db

thanks!

Comment 18

[Jake Maul [:jakem]]

I started this but had some internet trouble and my session got disconnected... when I got back in and tried it again, there were "no matching bugs found", so I guess it actually finished.

Closing this out... if anything more needs done, please re-open and let us know. Thanks!