931189 - fix feedback forms to be in line with 10k character max for description

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #929664 had us add a 10,000 character max for the description. However, there's no indication in the feedback form that the user's comment will be truncated.

This bug covers fixing that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P3 since this is kind of an edge case--not many people go over 10,000 characters so we can punt on it for a while.

Adding it to the current quarter queue.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Possible options:

1. JavaScript code to show the current character count and maximum character count and when the current is over the maximum, prevent the form from being submitted and make the text box red. Or some similar no-new-strings ux.

2. When the user submits a form with a description with more than 10,000 characters, return an error saying the description is too long. We can do this with the existing ResponseForm. This requires strings changes, though this might be an edge case so the fact it requires strings changes might not matter a whole lot.


Are there other things we could/should do?

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just did something similar with the Firefox OS feedback form where it disables the submit button and puts a red border around the description when it's over the character max. That coupled with a character counter should cover all the issues here "good enough" without requiring any strings changes.

One note is that the character counter should work correctly for both RTL and LTR.

I think that's about 2 points of work. Marking it as such.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I added a max character count and a counter (part of the code was already there).

PR: https://github.com/mozilla/fjord/pull/199

This doesn't involve any l10n changes, so it can go through. Also, it doesn't prevent the form from being submitted. I decided that with the visual indicator plus the fact that we truncate the description if it's too long on the backend, the extra validation and messaging code wasn't really needed and is easy to get around by miscreants anyhow.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in:

https://github.com/mozilla/fjord/commit/db2a2d3
https://github.com/mozilla/fjord/commit/fd7c877
https://github.com/mozilla/fjord/commit/6f64900

It's not great, but it's good enough. I look forward to the day when we can fix/redo these feedback forms.

Pushed to production just now.