931274 - Windows 8.1 questions get incorrectly identified as Windows NT 4.0

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Michael Cooper [:mythmon]]

A contributor thread about windows 8.1 [0] pointed out that Windows 8.1 is getting miscategorized as Windows NT 4.0 in the AAQ. If I had to guess, I would say this is because the bump that was made the NT version in the useragent is going unrecognized by us, and so we fall back to the first or last version specified.

This should be an easy fix. Tossing it in the next sprint (which begins Tuesday), and marking it as 1pt.

This should be a pretty easy bug if you want to get into learning the backend of SUMO. Adding the mentor flags. Let me know if you want to work on this.

[0]: https://support.mozilla.org/en-US/forums/contributors/709688#post-54817

Comment 1

[[:philipp]]

i think i can take this one (& i'm already going through TFM at kitsune.readthedocs.org)

Comment 2

[[:philipp]]

https://github.com/mozilla/kitsune/pull/1694

Comment 3

[Tobias (:Tobbi) Markus]

Though shalt be assigned!

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/compare/e9a8b76e9838...5a5ab5cc9ce9

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod by rdalal.

Thanks philipp!

Comment 6

[[:philipp]]

i've asked a test question at https://support.allizom.org/en-US/questions/973127 and it got detected correctly, however it is not tagged with "Windows 8.1" in the forum overview yet. is it necessary to add another string somewhere in the codebase or are the tags getting generated automatically?

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to philipp from comment #6)
> i've asked a test question at
> https://support.allizom.org/en-US/questions/973127 and it got detected
> correctly, however it is not tagged with "Windows 8.1" in the forum overview
> yet. is it necessary to add another string somewhere in the codebase or are
> the tags getting generated automatically?

Can you try again now? Looking at the code, it only adds the tag if it already has been created before. I just created a Windows 8.1 tag on stage and prod.

Comment 8

[[:philipp]]

thanks ricky, now it's working: https://support.allizom.org/en-US/questions/973128