931301 - Update content styles to better match assets shared by Sean

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Design, defect)

Description

[John Karahalis [:openjck]]

We updated content styles with the following pull request:
https://github.com/mozilla/kuma/pull/1546

The pull request was not meant to be pixel-perfect with what Sean requested. There are some discrepancies (all minor) that might need to be corrected. They are listed here.

-----

"Events" and "JavaScript" boxes incorrectly use bullets
http://imgur.com/a/IDiiB

Values are not lined up in "Events" and "JavaScript" sections
http://imgur.com/a/2R2Ht

Text/background of active tab not dark enough
http://imgur.com/a/LWC5Y

API reference has rounded corners
http://imgur.com/a/CXYjY

Spec status icons are too big
http://imgur.com/a/DFKXC

Tables have different background color
http://imgur.com/a/pLJQR

Padding of "Requires Gecko" section too great
http://imgur.com/a/b6cEs

<code> font is different (might just be me--Linux fonts can be wonky)
http://imgur.com/a/LVCXb

Low weight of non-header text, especially code samples (might just be me--Linux fonts can be wonky)
http://imgur.com/a/P3gAu

Comment 1

[Jean-Yves Perrier [:teoli]]

Quick question, I see some of the new styles, so I assume there are on prod. But what I see is very different of what you have in your screenshots as 'on Prod'.

Comment 2

[David Walsh :davidwalsh]

Will address these items when I get time today.

Comment 3

[David Walsh :davidwalsh]

I've pushed these updates to prod via Template:CSS.

FWIW, I couldn't address the table issue, mainly because those images look exactly the same to me.

Comment 4

[John Karahalis [:openjck]]

(In reply to Jean-Yves Perrier [:teoli] from comment #1)
> Quick question, I see some of the new styles, so I assume there are on prod.
> But what I see is very different of what you have in your screenshots as 'on
> Prod'.

That's because only the CustomCSS changes have been published. The rest have been merged into master but not yet pushed to production. I was wrong to call those "on prod" and should have called them "on master" instead.

(In reply to David Walsh :davidwalsh from comment #3)
> I've pushed these updates to prod via Template:CSS.
> 
> FWIW, I couldn't address the table issue, mainly because those images look
> exactly the same to me.

The tables have slightly different background colors, which you can see if you look very close or use a color select tool in a photo editor to compare the two. Not a big difference.

Comment 5

[John Karahalis [:openjck]]

Looks like this one is still an issue.
http://imgur.com/a/LWC5Y

Quoting Sean:
> only issue I see is the desktop tab bgcolor on Compatibility tables not being a match.

Comment 6

[John Karahalis [:openjck]]

Comment 5 fixed!