931389 - Deprecate and remove CanvasRenderingContext2D.mozDash/mozDashOffset

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Originally part of bug 768067, but didn't happen there.

Comment 2

[Thomas Wisniewski]

Attachment: 931389-remove-mozDash-and-mozDashOffset.diff

Since the unprefixed versions of these features have been in Firefox since version 27, the MDN page for the standard version has noted that they're deprecated since at least July of last year, and no addons on DXR are only using the prefixed versions, I think it's probably safe to go ahead and remove them now. Here's a patch which does so. Try seems fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=035996f88667

Intent to unship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/UIudMABegcY

Comment 3

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8791582 [details] [diff] [review]
931389-remove-mozDash-and-mozDashOffset.diff

Review of attachment 8791582 [details] [diff] [review]:
-----------------------------------------------------------------

I'm ok with this, but let's give dev-platform a little more time to raise any possible objections.

Comment 4

[Thomas Wisniewski]

I still haven't received any feedback on the dev-platform thread, George. Would you still like to wait a while longer?

Comment 5

[George Wright (:gw280) (needinfo me!)]

Nope, let's go ahead with this.

Comment 6

[Thomas Wisniewski]

Attachment: 931389-remove-mozDash-and-mozDashOffset.diff

Alright then. Here's a rebased version of the patch. A fresh try run* seems fine, so I'm carrying over r+ and requesting check-in.

* https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbc5436cc4cb2f370c38806703dda9126f64f00d

Comment 7

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/canvas-2d-mozdash-and-mozdashoffset-have-been-removed/

Comment 8

[Ryan VanderMeulen [:RyanVM]]

The webidl changes need DOM peer review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68ec683e9a5c
remove CanvasRenderingContext2D.mozDash/mozDashOffset. r=gw280, r=baku

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68ec683e9a5c

Comment 11

[Chris Mills [:cmills]]

I think that since these have been marked for obsolescence for so long, have been removed completely, and were Gecko-only anyway, they can be removed from the docs. I've removed the mentions from
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D#Non-standard_APIs

I've also added a note to the Fx52 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/52#Others