931428 - GStreamerLoader.cpp:47:24: error: ‘nullptr’ was not declared in this scope

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

Another nullptr issue.

Comment 1

[Bill Gianopoulos [:WG9s]]

Attachment: Patch

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19e0d06f37e8

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/19e0d06f37e8

Comment 4

[Bill Gianopoulos [:WG9s]]

Comment on attachment 822848 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 784739
User impact if declined: released source will not compile with GCC 4.5
Testing completed (on m-c, etc.): Patch has been on mozilla-central since 10/28/2013
Risk to taking this patch (and alternatives if risky): very little risk trivial fix
String or IDL/UUID changes made by this patch: none

Comment 5

[Bill Gianopoulos [:WG9s]]

I nominated this because it seems from comments in bug 931427 that there is an intention to have the beta and released source compile under GCC 4.5.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d81ce166fe8e