Make QS/DOM binding unwrapping like XPCConvert unwrapping for COWs

RESOLVED FIXED in Firefox 28

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(firefox28 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 822882 [details] [diff] [review]
Port hack from XPCConvert unwrapping to XPCQuickStubs

This came up in bug 918345 (see bug 918345 comment 9).
Attachment #822882 - Flags: review?(bobbyholley+bmo)
Comment on attachment 822882 [details] [diff] [review]
Port hack from XPCConvert unwrapping to XPCQuickStubs

Review of attachment 822882 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley with the below.

::: js/xpconnect/src/XPCQuickStubs.cpp
@@ +537,5 @@
> +        // Hack - For historical reasons, wrapped chrome JS objects have been
> +        // passable as native interfaces. We'd like to fix this, but it
> +        // involves fixing the contacts API and PeerConnection to stop using
> +        // COWs. This needs to happen, but for now just preserve the old
> +        // behavior.

Please add a comment here indicating that this is duplicated in XPCConvert, and a comment in the XPCConvert code indicating the same thing. Otherwise, I'll miss this when I land bug 821573.
Attachment #822882 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/555f1c5baad7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
status-firefox28: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.