931469 - Tapping an .apk file download link results in 2 downloads starting, one of which never completes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Bill Gianopoulos [:WG9s]]

Clicking on a download link such as http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android/fennec-27.0a1.multi.android-arm.apk results in 2 downloads starting instead of 1.  One of the 2 downloads never completes.

Regression window http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=23c23b472a4f&tochange=177bf37a49f5

Comment 1

[Bill Gianopoulos [:WG9s]]

Looks like perhaps bug 780379.  I will try backing it out and report back.

Comment 2

[Bill Gianopoulos [:WG9s]]

I have verified via backout, that the following check-in for bug 780379 is the regressor here:

http://hg.mozilla.org/mozilla-central/rev/04f77c1e3337

Comment 3

[Richard Newman [:rnewman]]

Possibly also related to the occasional "Unfortunately, Fennec has stopped" notification I get when triggering a download?

Comment 4

[Richard Newman [:rnewman]]

Wes, see Bug 780379 Comment 55.

Comment 5

[Bill Gianopoulos [:WG9s]]

Attachment: Remove redundant app.launch(aLauncher.source)

Comment 6

[Bill Gianopoulos [:WG9s]]

I should give credit here to :rnewman.  It was his comment above that led to this fix.

Comment 7

[Richard Newman [:rnewman]]

Flagging for tracking in case this misses the merge.

Comment 9

[Bill Gianopoulos [:WG9s]]

It is hard to get testing on this since the tree is closed so it can't land, but I am including this in my own daily builds available at my own website http://www.wg9s.com/mozilla/firefox/

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/858d68a25e5d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/858d68a25e5d

Comment 12

[Aaron Train [:aaronmt]]

Looks good on trunk, please nominate for Aurora.

Comment 13

[Bill Gianopoulos [:WG9s]]

I was planning on letting it bake for a week, unless you think I should just do it sooner.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Bill Gianopoulos [:WG9s] from comment #13)
> I was planning on letting it bake for a week, unless you think I should just
> do it sooner.

Only if the patch was more complicated. This looks like a simple typo-fix. Sooner is better.

Comment 15

[Bill Gianopoulos [:WG9s]]

Comment on attachment 822994 [details] [diff] [review]
Remove redundant app.launch(aLauncher.source)

[Approval Request Comment]
Bug caused by (feature/regressing bug #):  780379
User impact if declined: Results in a nasty regression when using the browser to download files.
Testing completed (on m-c, etc.): Is on m-c.
Risk to taking this patch (and alternatives if risky): Not risky, essentially a typo-fix.
String or IDL/UUID changes made by this patch: none

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f2e1bef61fee

Comment 17

[Flaviu Cos]

Verified as fixed on build: aurora 27.0a2 (11.13.2013).
Device: Asus Transformer Tab (Android 4.0.3)