931486 - x86 assembly spew fixes

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: x86-spew-fixes.patch

Another fun round of x86 spew fixes. This implements all the FIXMEs that I'm currently seeing.

Comment 1

[Sean Stangl [:sstangl]]

Comment on attachment 822914 [details] [diff] [review]
x86-spew-fixes.patch

Review of attachment 822914 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/assembler/assembler/X86Assembler.h
@@ +1769,1 @@
>              m_formatter.oneByteOp64(OP_MOV_EvGv, src, addr);

nit: excess indentation can be removed.

Comment 2

[Dan Gohman [:sunfish]]

(In reply to Sean Stangl [:sstangl] from comment #1)
> Comment on attachment 822914 [details] [diff] [review]
> x86-spew-fixes.patch
> 
> Review of attachment 822914 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/assembler/assembler/X86Assembler.h
> @@ +1769,1 @@
> >              m_formatter.oneByteOp64(OP_MOV_EvGv, src, addr);
> 
> nit: excess indentation can be removed.

Fixed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd6f10de22b1

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dd6f10de22b1

Comment 4

[u279076]

(In reply to Phil Ringnalda (:philor) from comment #3)
> https://hg.mozilla.org/mozilla-central/rev/dd6f10de22b1

Can you please confirm the target milestone is correct? This is Firefox 27 according to http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/10/2013-10-28-03-02-05-mozilla-central/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Same as the other one. On a merge day, you can't say for sure without looking at the repos.

Comment 6

[u279076]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> Same as the other one. On a merge day, you can't say for sure without
> looking at the repos.

Right, thanks.