931573 - Samsung Galaxy S2 crashes on gralloc Android's HAL cause Framebuffer::lastHandle is not initialized to NULL

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Juan Gomez [:_AtilA_] (CET/CEST)]

I was getting a crash in Samsung's (well, right now it's the Cyanogenmod one) gralloc implementation for exynos4 devices, cause GonkDisplayJB::Post( mFBSurface->lastHandle, ... ) was calling gralloc's HAL fb_post( buffer = <uninitialized value>, ... ) with an uninitialized pointer variable (lastHandle). This was the backtrace:

#0  0x40169ba8 in validate (h=0xa5a5a5a5) at hardware/samsung/exynos4/hal/libgralloc_ump/../include/gralloc_priv.h:228
#1  fb_post (dev=0x405380c0, buffer=0xa5a5a5a5) at hardware/samsung/exynos4/hal/libgralloc_ump/framebuffer_device.cpp:72
#2  0x0001442a in mozilla::GonkDisplayJB::Post (this=0x4051a380, buf=0xa5a5a5a5, fence=-1515870811) at ../../../../gecko/widget/gonk/libdisplay/GonkDisplayJB.cpp:188
#3  0x41d280d2 in SwapBuffers (this=0x47c23800) at ../../../gecko/gfx/gl/GLContextProviderEGL.cpp:600
#4  mozilla::gl::GLContextEGL::SwapBuffers (this=0x47c23800) at ../../../gecko/gfx/gl/GLContextProviderEGL.cpp:595
#5  0x41cf6f2a in mozilla::layers::CompositorOGL::EndFrame (this=0x47c374a0) at ../../../gecko/gfx/layers/opengl/CompositorOGL.cpp:1320
#6  0x41d09ada in mozilla::layers::LayerManagerComposite::Render (this=0x46fd3200) at 
(...)

Comment 1

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: 0001-Bug-931573-Fixes-a-crash-in-some-gralloc-s-HAL-imple.patch

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 823026 [details] [diff] [review]
0001-Bug-931573-Fixes-a-crash-in-some-gralloc-s-HAL-imple.patch

Review of attachment 823026 [details] [diff] [review]:
-----------------------------------------------------------------

I told Juan on IRC that I could review this for him, and it looks like a no-brainer r+ to me.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/99e2b83f874c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/99e2b83f874c