Closed Bug 931641 Opened 6 years ago Closed 6 years ago

Intermittent test_contextmenu_nested.xul | open inner popup event type DOMMenuItemInactive fired - got DOMMenuItemInactive, expected popupshowing, | open inner popup event target ID outermenu - got outermenu, expected innermain, | Test timed out.

Categories

(Toolkit :: XUL Widgets, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox26 --- wontfix
firefox27 --- fixed
firefox28 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: philor, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=29750105&tree=Mozilla-Inbound
Ubuntu ASAN VM 12.04 x64 mozilla-inbound opt test mochitest-5 on 2013-10-27 16:23:29 PDT for push a2eecdb6d6b0
slave: tst-linux64-ec2-035

16:36:36     INFO -  131426 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | open inner popup event type DOMMenuItemInactive fired - got DOMMenuItemInactive, expected popupshowing
16:36:36     INFO -  131427 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | open inner popup event target ID outermenu - got outermenu, expected innermain
(screenshot)
16:41:59     INFO -  131428 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | Test timed out.
16:41:59     INFO -  131429 INFO TEST-END | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | finished in 320505ms
Assignee: nobody → bugs
Blocks: 930793
Attached patch contextmenu_test.diff (obsolete) — Splinter Review
The patch at least makes this highly racy test pass locally on linux.

(Enn is on pto, I think, so had to find some other victim for reviewing.)
Attachment #832598 - Flags: review?(ehsan)
Comment on attachment 832598 [details] [diff] [review]
contextmenu_test.diff

boo, this makes the test to fail on windows.
Attachment #832598 - Flags: review?(ehsan)
I can't figure out anything else than this which passes both on Windows and Linux.
The problem is that the test relies on certain kind of native<->gecko event loop
interaction.  I looked at all the DOM events fired during the testing time, but
there just isn't anything which works reliably, and it doesn't make much sense
to add a new DOM event just for this test.


Other option is to disable the test on linux, I guess.
Attachment #832598 - Attachment is obsolete: true
Attachment #8337776 - Flags: review?(ehsan)
Or there could be just different version for linux and windows. (and the test is disabled on mac).


But perhaps better to try out the timeout first.
Comment on attachment 8337776 [details] [diff] [review]
contextmenu_test_2.diff

Review of attachment 8337776 [details] [diff] [review]:
-----------------------------------------------------------------

I really really wanted to minus this if I knew of a better way to fix it.  :(  Please add a comment to the test at least saying how horrible this hack is, and why it exists etc.
Attachment #8337776 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/e6484a878eee
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.