Closed Bug 931641 Opened 7 years ago Closed 7 years ago
_contextmenu _nested .xul | open inner popup event type DOMMenu Item Inactive fired - got DOMMenu Item Inactive, expected popupshowing, | open inner popup event target ID outermenu - got outermenu, expected innermain, | Test timed out .
https://tbpl.mozilla.org/php/getParsedLog.php?id=29750105&tree=Mozilla-Inbound Ubuntu ASAN VM 12.04 x64 mozilla-inbound opt test mochitest-5 on 2013-10-27 16:23:29 PDT for push a2eecdb6d6b0 slave: tst-linux64-ec2-035 16:36:36 INFO - 131426 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | open inner popup event type DOMMenuItemInactive fired - got DOMMenuItemInactive, expected popupshowing 16:36:36 INFO - 131427 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | open inner popup event target ID outermenu - got outermenu, expected innermain (screenshot) 16:41:59 INFO - 131428 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | Test timed out. 16:41:59 INFO - 131429 INFO TEST-END | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | finished in 320505ms
The patch at least makes this highly racy test pass locally on linux. (Enn is on pto, I think, so had to find some other victim for reviewing.)
Comment on attachment 832598 [details] [diff] [review] contextmenu_test.diff boo, this makes the test to fail on windows.
I can't figure out anything else than this which passes both on Windows and Linux. The problem is that the test relies on certain kind of native<->gecko event loop interaction. I looked at all the DOM events fired during the testing time, but there just isn't anything which works reliably, and it doesn't make much sense to add a new DOM event just for this test. Other option is to disable the test on linux, I guess.
Or there could be just different version for linux and windows. (and the test is disabled on mac). But perhaps better to try out the timeout first.
Comment on attachment 8337776 [details] [diff] [review] contextmenu_test_2.diff Review of attachment 8337776 [details] [diff] [review]: ----------------------------------------------------------------- I really really wanted to minus this if I knew of a better way to fix it. :( Please add a comment to the test at least saying how horrible this hack is, and why it exists etc.
Attachment #8337776 - Flags: review?(ehsan) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.