Closed
Bug 931697
Opened 11 years ago
Closed 11 years ago
WebTelephony: Add marionette test cases for multi-sim
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 6 - 12/6
People
(Reporter: aknow, Assigned: aknow)
References
Details
Attachments
(1 file, 4 obsolete files)
10.08 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
1. dsds outgoing call test 2. startDSDSTest() macro in head.js
Attachment #823854 -
Attachment is obsolete: true
Attachment #827880 -
Flags: review?(htsai)
Comment 3•11 years ago
|
||
Comment on attachment 827880 [details] [diff] [review] Add dsds outgoing call marionette test Review of attachment 827880 [details] [diff] [review]: ----------------------------------------------------------------- General comment: Please don't forget manifest.in ::: dom/telephony/test/marionette/head.js @@ +160,5 @@ > + > + if (numRIL > 1) { > + startTest(test); > + } else { > + log('Not a DSDS environment. Test is skipped.'); nit: use double quotation mark. ::: dom/telephony/test/marionette/test_dsds_outgoing.js @@ +130,5 @@ > + > + return deferred.promise; > +} > + > +function makeCallForServiceId(number, serviceId) { I'd rename it testOutgoingCallForServiceId. And I'd like to see 'testIncomingCallForServiceId' too. :) @@ +139,5 @@ > + .then(() => dial(number, serviceId)) > + .then(call => { outCall = call; }) > + .then(() => { > + is(outCall.serviceId, serviceId); > + return checkAll(outCall, [outCall], [outInfo.ringing]); We don't need 'return', i.e. |checkAll(outCall, [outCall], [outInfo.ringing]);| is fine.
Attachment #827880 -
Flags: review?(htsai)
Assignee | ||
Comment 4•11 years ago
|
||
> @@ +139,5 @@
> > + .then(() => dial(number, serviceId))
> > + .then(call => { outCall = call; })
> > + .then(() => {
> > + is(outCall.serviceId, serviceId);
> > + return checkAll(outCall, [outCall], [outInfo.ringing]);
>
> We don't need 'return', i.e. |checkAll(outCall, [outCall],
> [outInfo.ringing]);| is fine.
I think 'return' is needed.
.then(() => {
is(outCall.serviceId, serviceId);
return checkAll(outCall, [outCall], [outInfo.ringing]);
})
checkAll() return a promise. We should return it. Otherwise, the next .then part will be execute immediately.
Assignee | ||
Comment 5•11 years ago
|
||
1. Add incoming call test. 2. I would like to rename the filename to "test_dsds_normal_call" (also in manifest). This part is not included in the patch to avoid the difficulty of diff view after renaming.
Attachment #827880 -
Attachment is obsolete: true
Attachment #8342195 -
Flags: review?(htsai)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8342198 -
Flags: review?(htsai)
Comment 7•11 years ago
|
||
Comment on attachment 8342195 [details] [diff] [review] #2 multisim test (Add dsds outgoing call marionette test) Review of attachment 8342195 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8342195 -
Flags: review?(htsai) → review+
Comment 8•11 years ago
|
||
Comment on attachment 8342198 [details] [diff] [review] file rename Review of attachment 8342198 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Please squish the two patches into one for landing, thanks.
Attachment #8342198 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #8343055 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #8342198 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #8342195 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d4c47f6b0eb2
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 11•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/08d07ae47342
Flags: in-testsuite+
Keywords: checkin-needed
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08d07ae47342
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in
before you can comment on or make changes to this bug.
Description
•