931765 - When you enter your login or password wrong, the error message shown "The username or password you entered is not valid" should be edited to "The login or password you entered is not valid"

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[tinajohnson.1234]

Attachment: Wrong error message. It should display, "The email-id or password you entered is not valid. "

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0.1 (Beta/Release)
Build ID: 20120907231657

Steps to reproduce:

When I entered my email-id wrong, I encountered the wrong message.


Actual results:

Error message:"The username or password you entered is not valid. "


Expected results:

"The email-id or password you entered is not valid. "

Comment 1

[Frédéric Buclin]

(In reply to tinajohnson.1234 from comment #0)
> Expected results:
> 
> "The email-id or password you entered is not valid. "

It should say "login", not "email-id".

Comment 2

[tinajohnson.1234]

(In reply to Frédéric Buclin from comment #1)
> (In reply to tinajohnson.1234 from comment #0)
> > Expected results:
> > 
> > "The email-id or password you entered is not valid. "
> 
> It should say "login", not "email-id".
When I checked the bugzilla's of Mozilla, KDE, MediaWiki the placeholders of the login input field was email-id. But "login" works too.

Comment 3

[Andre Klapper]

(In reply to tinajohnson.1234 from comment #2)
> (In reply to Frédéric Buclin from comment #1)
> > It should say "login", not "email-id".
> When I checked the bugzilla's of Mozilla, KDE, MediaWiki the placeholders of
> the login input field was email-id. But "login" works too.

That's because those three Bugzillas only allow email addresses as logins.
However Bugzilla's configuration also allows LDAP usernames for example, so "email-id" would be wrong.

Comment 4

[tinajohnson.1234]

Attachment: Error message and header title for invalid login changed.

Error message for invalid login changed from "The username or password you entered is not valid." to "The login or password you entered is not valid.". Also changed the header title from 'Bugzilla – Invalid Username Or Password' to 'Bugzilla – Invalid Login Or Password'

Comment 5

[01tonythomas]

Comment on attachment 825936 [details] [diff] [review]
Error message and header title for invalid login changed.

Review of attachment 825936 [details] [diff] [review]:
-----------------------------------------------------------------

+1 Essential as the error message is misleading in the bugzilla login.

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 825936 [details] [diff] [review]
Error message and header title for invalid login changed.

Change looks fine although I had to do patch -p1 to get it to apply. Please created your future diffs from within the root bugzilla directory. r=dkl

Thanks
dkl

Comment 7

[Frédéric Buclin]

Comment on attachment 825936 [details] [diff] [review]
Error message and header title for invalid login changed.

>   [% ELSIF error == "invalid_username_or_password" %]

I think the error tag should also be reworded to invalid_login_or_password.

Comment 8

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #7)
> Comment on attachment 825936 [details] [diff] [review]
> Error message and header title for invalid login changed.
> 
> >   [% ELSIF error == "invalid_username_or_password" %]
> 
> I think the error tag should also be reworded to invalid_login_or_password.

Ah good point and sorry missed that. Can fix on check in unless you think a new patch is in order.

dkl

Comment 9

[tinajohnson.1234]

(In reply to David Lawrence [:dkl] from comment #8)
> (In reply to Frédéric Buclin from comment #7)
> > Comment on attachment 825936 [details] [diff] [review]
> > Error message and header title for invalid login changed.
> > 
> > >   [% ELSIF error == "invalid_username_or_password" %]
> > 
> > I think the error tag should also be reworded to invalid_login_or_password.
> 
> Ah good point and sorry missed that. Can fix on check in unless you think a
> new patch is in order.
I'll upload the patch soon.
> 
> dkl

Comment 10

[tinajohnson.1234]

Attachment: Error message and header title and error tag of invalid login changed in user-error.html.tmpl, Auth.pm, Constants.pm

Comment 11

[01tonythomas]

Comment on attachment 826285 [details] [diff] [review]
Error message and header title and error tag of invalid login changed in user-error.html.tmpl, Auth.pm, Constants.pm

Review of attachment 826285 [details] [diff] [review]:
-----------------------------------------------------------------

looks done, this time.

Comment 12

[Teemu Mannermaa (:wicked)]

Comment on attachment 826285 [details] [diff] [review]
Error message and header title and error tag of invalid login changed in user-error.html.tmpl, Auth.pm, Constants.pm

Not sure if a new patch was needed but since it's here, it needs a new review.

Comment 13

[Frédéric Buclin]

The patch should be reviewed *before* being approved....

Comment 14

[David Lawrence [:dkl]]

Comment on attachment 826285 [details] [diff] [review]
Error message and header title and error tag of invalid login changed in user-error.html.tmpl, Auth.pm, Constants.pm

r=dkl

Comment 15

[David Lawrence [:dkl]]

Thanks for the patch!

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/Auth.pm
modified Bugzilla/WebService/Constants.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8805.