93177 - Add support for box-direction to box.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

Box does not currently support box-direction.  Everything is done in CSS.  The 
box code just needs to be taught to flip its layout based off the dir 
attribute and the box-direction property.

Comment 1

[David Hyatt]

Attachment: Add direction support to box and also teach splitter about direction (so you can put the sidebar on the right if ya want)

Comment 2

[David Hyatt]

Attachment: A better patch. Look at this one! :)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: initial sidebar side-switching mechanism (test case, untested!)

Comment 4

[jag (Peter Annema)]

Weeeee! Looks nice and stuff. Wish I could r= this, but don't feel confident
enough about this code. Maybe you can walk me through it later today?

Comment 5

[David Hyatt]

Attachment: Patch that ensures horizontal boxes pay attention to the "direction" CSS property (for BIDI)

Comment 6

[David Hyatt]

I need r/sr on the last patch only.  Thanks!  Jag has passed out, so I need 
someone else to review.  Hewitt? Blake? Ben?

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

OK. I think I'm comfortable with this. Code seems reasonable, changes should
either break the world or work perfectly (one would hope!) so run the product,
open a few dialogs, and if everything works, sr=ben!

Comment 8

[Stuart Parmenter]

r=pavlov

Comment 9

[David Hyatt]

Fixed.