93180 - Consolidate stack and bulletinboard

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

bulletinboard's functionality should be folded into stack.

Comment 1

[Brian King [:kinger]]

Could you elaborate a little on the implications of this. Does it mean 
bulletinboard will be obsolete?

Comment 2

[David Hyatt]

No, I'll keep supporting the tag, but it will be deprecated.  Basically <stack>
and <bulletinboard> are the same widget, so you'll be able to just use a <stack>.

Comment 3

[David Hyatt]

Attachment: Fold bulletinboard's functionality into stack and remove bulletin board files from the tree

Comment 4

[David Hyatt]

One thing missing from the diff... I change the rule for bulletinboard to be

bulletinboard {
  display: -moz-stack;
}

for backwards compatibility.

Ready for r/sr.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Looked over the patch.  With the addition hyatt put in a comment, looks good. 
For whatever it's worth, r=rjesup.  My only comment is that the surrounding
source in some of the functions appears to use tabs,  but as per various
discussions, this is fine so long as the patch doesn't and removed them from
changed lines, which it appears to.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 47402 [details] [diff] [review]
Fold bulletinboard's functionality into stack and remove bulletin board files from the tree

nsStackLayout.cpp is an indentation nightmare (even before these changes), fix it if you wanto.

sr=jst

Comment 7

[David Hyatt]

There are some minor issues with this patch.  I'm going to forget about the r/sr
and go back to the drawing board first.

Comment 8

[David Hyatt]

Attachment: Better patch. Handles non-stretchy positioned elements within the stack.

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 48272 [details] [diff] [review]
Better patch.  Handles non-stretchy positioned elements within the stack.

It doesn't seem like AddOffset() needs to be virtual, so that could be removed, other than that, sr=jst

Comment 10

[David Hyatt]

Patch that incorporates jst feedback and jag feedback.

Comment 11

[David Hyatt]

Attachment: New patch

Comment 12

[David Hyatt]

Attachment: Patch with a perf optimization to avoid querying for left/top on unpositioned elts.

Comment 13

[David Hyatt]

Would like another round of r/sr on the newest patch.

Comment 14

[Johnny Stenback (:jst)]

Comment on attachment 48354 [details] [diff] [review]
Patch with a perf optimization to avoid querying for left/top on unpositioned elts.

sr=jst

Comment 15

[David Hyatt]

Fixed. 

Comment 16

[David Hyatt]

Note that a stacks test page link has been added to the XUL test suite in the 
Debug menu.