931900 - nsIPromptService.prompt's default value parameter acts differently between desktop and mobile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jason Barnabe (np)]

Firefox 24 on Android
Firefox 24 on Linux

"aValue" is an inout parameter of nsIPromptService.prompt that sets the default text and gets set to the user-entered value. When this parameter is set to an empty object or to an object with a null "value" member, there is different behaviour between mobile (Android) and desktop. On mobile, the pre-filled value is "null". On desktop, there is no pre-filled value. Desktop's behaviour seems more correct to me.

Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService).prompt(window, "test", "test", {}, null, {});

or

Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService).prompt(window, "test", "test", {value: null}, null, {});

As a workaround, I can do this:

Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService).prompt(window, "test", "test", {value: ""}, null, {});

Comment 1

[Wesley Johnston (:wesj)]

This fix is trivial, but I have a bunch of WIP for tests for these exact things in bug 757481 that are oh-so-close to landing. Holding off until I have that in place :)

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Forgot about this. The tests are a bit hung up, but we should fix this.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8377865 [details] [diff] [review]
Patch

Review of attachment 8377865 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comment addressed.

::: mobile/android/components/PromptService.js
@@ +303,5 @@
>  
>    nsIPrompt_prompt: function nsIPrompt_prompt(aTitle, aText, aValue, aCheckMsg, aCheckState) {
>      let p = this._getPrompt(aTitle, aText, null, aCheckMsg, aCheckState);
>      p.setHint("prompt");
> +    this.addTextbox(p, aValue.value);

With this change, autofocus will be undefined. Unintentional change?

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/547342061dc3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/547342061dc3