931974 - Interface 'nsIDOMHTMLElement', in file 'nsIDOMHTMLElement.idl' needs a new IID for Firefox 26

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Our check IID scripts have uncovered this as a potential need for revving up the IID - based on changes in bug 901060 - can you please check, confirm if needed, and if so attach a patch. We'll need this landed today for our first FF26 beta if it's not a false positive.

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

The change was binary-compatible, so it's not obvious we need the IID rev on the branch, for what it's worth.  Do we?

Comment 3

[David Zbarsky (:dzbarsky)]

We renamed one of the functions on nsIDOMHTMLElement. Why would that be binary compatible?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Because it's a virtual function, so code compiled against the old version of the interface (which is calling it via offset in the vtable) will still work.

It's not _source_ compatible, in that if you recompile your code won't compile.  But it's binary compatible.

Comment 5

[David Zbarsky (:dzbarsky)]

(In reply to Boris Zbarsky [:bz] from comment #4)
> Because it's a virtual function, so code compiled against the old version of
> the interface (which is calling it via offset in the vtable) will still work.
> 
> It's not _source_ compatible, in that if you recompile your code won't
> compile.  But it's binary compatible.

Ah, that makes sense.

Comment 6

[Benjamin Smedberg]

Indeed, this doesn't appear to require any IID change.