Tabzilla formatting issues

VERIFIED FIXED

Status

Websites
careers.mozilla.org
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: Gregory Jost, Assigned: shobson, Mentored)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 823680 [details]
Screen Shot 2013-10-28 at 16.56.48.png

Not sure if this has to do with dev environment but Tabzilla seems to have a few formatting issues compared to the live version:
- extra pixel on top
- letter spacing for column headers is too big causing "innovations" to break up. Also not bolded.
- font-sze for "Search" is also smaller

Comment 1

5 years ago
Hmm perhaps some of the styles for the careers site are being applied to tabzilla.

Assigning to Steph to investigate.
Assignee: nobody → sjhobson
(Assignee)

Comment 2

5 years ago
Looks like there are some styles Tabzilla is inheriting from the page that it sits on rather than from tabzilla.css.

Comment 3

5 years ago
Commit pushed to master at https://github.com/mozilla/lumbergh

https://github.com/mozilla/lumbergh/commit/3f45db3756a6f696cc410ca31571e18c9de4c80f
932108 - Tabzilla formatting

Fix bug 932108. Changed conflicting font declarations. Added inherited styles that are different from moz.org as specific declarations for tabzilla.

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 933310

Comment 4

5 years ago
Created attachment 825578 [details]
Screen Shot 2013-10-31 at 3.42.24 PM.png

Looks better but still off. On the left is careers on the right is moz.org

Notice the height of tabzilla is larger on careers and the fonts are different.

Comment 5

5 years ago
Removing dependency on 933310, this bug is atomic and covers just issues with the careers css influencing tabzilla.
Status: RESOLVED → REOPENED
No longer depends on: 933310
Resolution: FIXED → ---

Updated

4 years ago
Whiteboard: [mentor=booboobenny+bugzilla@gmail.com]
Mentor: booboobenny+bugzilla
Whiteboard: [mentor=booboobenny+bugzilla@gmail.com]

Comment 6

4 years ago
Submitted a PR that should completely fix this issue.

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED

Comment 8

4 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b6a2526377500f9f490d696c6e6e0301b4010f45
bug 932108 - Tabzilla formatting issues

Repositioned the `Search` placeholder by adjusting the line-height. It was affected by css from the body.

https://github.com/mozilla/bedrock/commit/8a978012f7034b3fc5dbb26acea025c0643ea471
Merge pull request #2249 from rubenvereecken/new-issue-932108

bug 932108 - Tabzilla formatting issues
http://careers.mozilla.org looks close enough that I think we can call this verified. :D
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.