932108 - Tabzilla formatting issues

Status: VERIFIED FIXED

(Websites :: careers.mozilla.org, defect)

Description

[Gregory Jost]

Attachment: Screen Shot 2013-10-28 at 16.56.48.png

Not sure if this has to do with dev environment but Tabzilla seems to have a few formatting issues compared to the live version:
- extra pixel on top
- letter spacing for column headers is too big causing "innovations" to break up. Also not bolded.
- font-sze for "Search" is also smaller

Comment 1

[Ben (:bensternthal)]

Hmm perhaps some of the styles for the careers site are being applied to tabzilla.

Assigning to Steph to investigate.

Comment 2

[Stephanie Hobson [:shobson]]

Looks like there are some styles Tabzilla is inheriting from the page that it sits on rather than from tabzilla.css.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/lumbergh

https://github.com/mozilla/lumbergh/commit/3f45db3756a6f696cc410ca31571e18c9de4c80f
932108 - Tabzilla formatting

Fix bug 932108. Changed conflicting font declarations. Added inherited styles that are different from moz.org as specific declarations for tabzilla.

Comment 4

[Ben (:bensternthal)]

Attachment: Screen Shot 2013-10-31 at 3.42.24 PM.png

Looks better but still off. On the left is careers on the right is moz.org

Notice the height of tabzilla is larger on careers and the fonts are different.

Comment 5

[Ben (:bensternthal)]

Removing dependency on 933310, this bug is atomic and covers just issues with the careers css influencing tabzilla.

Comment 6

[Ruben Vereecken]

Submitted a PR that should completely fix this issue.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/lumbergh

https://github.com/mozilla/lumbergh/commit/2dc0625b0569bccefec5368d38ff39db2bd14a5a
fix bug 932108 - Tabzilla formatting issues

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b6a2526377500f9f490d696c6e6e0301b4010f45
bug 932108 - Tabzilla formatting issues

Repositioned the `Search` placeholder by adjusting the line-height. It was affected by css from the body.

https://github.com/mozilla/bedrock/commit/8a978012f7034b3fc5dbb26acea025c0643ea471
Merge pull request #2249 from rubenvereecken/new-issue-932108

bug 932108 - Tabzilla formatting issues

Comment 9

[Osmose [:osmose, :mkelly]]

http://careers.mozilla.org looks close enough that I think we can call this verified. :D