Add --e10s option to mach test commands

RESOLVED FIXED in mozilla28

Status

Testing
Mochitest
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Trunk
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 823748 [details] [diff] [review]
add-e10s-mach-option.patch

This patch adds an --e10s option to the mochitest-* commands.  The value if this option is passed on to the 'options' object (so it appears in the config as seem by the tests), to mozinfo (so it can be used as a condition in test manifest files) and controls the value of the 'browser.tabs.remote' preference in created profiles.

With this patch, I'm able to run all tests with the browser.tabs.remote preference set to true, while skipping all tests that are specified in the manifest as |skip-if = e10s|.

CCing Ted as he suggested this approach and requesting feedback from gps on the patch.
Attachment #823748 - Flags: feedback?(gps)
Comment on attachment 823748 [details] [diff] [review]
add-e10s-mach-option.patch

This looks like exactly what I had in mind.
Component: Build Config → Mochitest
Product: Core → Testing
Comment on attachment 823748 [details] [diff] [review]
add-e10s-mach-option.patch

Review of attachment 823748 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. You should request final review from someone in ATeam (ted, jmaher, ahal, etc), as this is really their code to manage.
Attachment #823748 - Flags: feedback?(gps) → feedback+
(Assignee)

Comment 3

4 years ago
Comment on attachment 823748 [details] [diff] [review]
add-e10s-mach-option.patch

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> This looks like exactly what I had in mind.

Awesome - you win the "who shall I ask for review?" quiz! :)
Attachment #823748 - Flags: review?(ted)
Comment on attachment 823748 [details] [diff] [review]
add-e10s-mach-option.patch

Review of attachment 823748 [details] [diff] [review]:
-----------------------------------------------------------------

Feels like we want to document this somewhere, but I'm not sure if it belongs in the mozinfo documentation since it's Mochitest-specific.
Attachment #823748 - Flags: review?(ted) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 825075 [details] [diff] [review]
Updated to runtest.py run by TBPL works

Sorry Ted, but the previous patch failed on try, when testrunner.py is run directly instead of by mach.

This patch is the same, except it adds the following chunk to testing/mochitest/mochitest_options.py:

+        [["--e10s"],
+        { "action": "store_true",
+          "default": False,
+          "dest": "e10s",
+          "help": "Run tests with electrolysis preferences and test filtering enabled.",
+        }],

The other alternative would have been to handle options.e10s failing in runtests.py with a getattr() call, but felt this was better as eventually we hope to have TBPL run the tests with --e10s on one tree.  I'm not comfortable carrying r+ forward on this, so re-requesting review.
Assignee: nobody → mhammond
Attachment #823748 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #825075 - Flags: review?(ted)
Comment on attachment 825075 [details] [diff] [review]
Updated to runtest.py run by TBPL works

Review of attachment 825075 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine.
Attachment #825075 - Flags: review?(ted) → review+
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/516f2e40f5dd

Some basic docs have been added to https://developer.mozilla.org/en-US/docs/Mochitest - it already had e10s info for Fennec, so I added a new section for e10s on Desktop.
https://hg.mozilla.org/mozilla-central/rev/516f2e40f5dd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.