Closed
Bug 932151
Opened 11 years ago
Closed 11 years ago
Enable Keyboard/IME API to run in Nightly without installing helper extension
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: xyuan, Assigned: xyuan)
References
Details
Attachments
(2 files, 2 obsolete files)
Currently we need a gaia extension keyboard@gaiamobile.org(https://github.com/mozilla-b2g/gaia/tree/7d7864ce51f3faac0f8f55e487a10ba5b58d226c/tools/extensions/keyboard) to support Keyboard/IME API in Firefox Nightly. Maintaining the extension makes us some trouble: 1. A source code file named forms.js is copied from gecko to that extension. It requires extra effort to sync the source code between gecko and gaia. We got some bugs when not syncing the file in time. 2. We cannot write mochitest for firefox nightly as the extension locates in gaia, not gecko. So I suggest we remove the gaia extension and support all its functions in gecko.
Assignee | ||
Updated•11 years ago
|
QA Contact: xyuan
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → xyuan
QA Contact: xyuan
Assignee | ||
Comment 1•11 years ago
|
||
The patch made the b2g specific file - forms.js available for desktop build. The file won't be loaded until keyboard/IME api is enabled.
Attachment #827949 -
Flags: review?(fabrice)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #827952 -
Flags: review?(fabrice)
Comment 3•11 years ago
|
||
You make me a happy panda! http://1.bp.blogspot.com/-Nw6h8-Jqh5k/UIgQXcnUo7I/AAAAAAAAAos/GgNgxIL_DyU/s400/happy+panda.jpg
Comment 4•11 years ago
|
||
Comment on attachment 827949 [details] [diff] [review] gecko patch v1 Review of attachment 827949 [details] [diff] [review]: ----------------------------------------------------------------- looks ok, but I don't see the moved form.js file in this patch. ::: dom/browser-element/BrowserElementChild.js @@ +24,5 @@ > > > if (!('BrowserElementIsPreloaded' in this)) { > + try { > + if(Services.prefs.getBoolPref("dom.mozInputMethod.enabled")) { nit: space after if ::: dom/ipc/preload.js @@ +87,5 @@ > } catch(e) { > } > > + try { > + if(Services.prefs.getBoolPref("dom.mozInputMethod.enabled")) { nit: if (...)
Attachment #827949 -
Flags: review?(fabrice) → feedback+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #4) > Comment on attachment 827949 [details] [diff] [review] > gecko patch v1 > > Review of attachment 827949 [details] [diff] [review]: > ----------------------------------------------------------------- > > looks ok, but I don't see the moved form.js file in this patch. > There is a block of moving forms.js to dom/inputmethod/ in the patch file as following, which doesn't show in the |diff| and |review| pages. rename from b2g/chrome/content/forms.js rename to dom/inputmethod/forms.js
Assignee | ||
Comment 6•11 years ago
|
||
Fix nits. https://tbpl.mozilla.org/?tree=Try&rev=d46eaa0b46c6
Attachment #827949 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 828422 [details] [diff] [review] gecko patch v2 Review of attachment 828422 [details] [diff] [review]: ----------------------------------------------------------------- The failure of chrome mochitest on Linux Opt of the try seems unrelated.
Attachment #828422 -
Flags: review?(fabrice)
Updated•11 years ago
|
Attachment #828422 -
Flags: review?(fabrice) → review+
Updated•11 years ago
|
Attachment #827952 -
Flags: review?(fabrice) → review+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/f2ed6b24269a Looks like this needs an updated Gaia PR.
Keywords: checkin-needed
Whiteboard: [leave open]
Updated•11 years ago
|
Whiteboard: [leave open]
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #9) > https://hg.mozilla.org/integration/b2g-inbound/rev/f2ed6b24269a > > Looks like this needs an updated Gaia PR. Thank you Ryan. PR updated.
Comment 12•11 years ago
|
||
Backed out by timdream's request, for causing bug 936324: remote: https://hg.mozilla.org/mozilla-central/rev/f003c386c77a
Assignee | ||
Comment 13•11 years ago
|
||
Fix a copy-paste error in dom/browser-element/BrowserElementChild.js caused loading chrome://global/content/forms.js failed. The diff with previous path is: diff --git a/dom/browser-element/BrowserElementChild.js b/dom/browser-element/BrowserElementChild.js --- a/dom/browser-element/BrowserElementChild.js +++ b/dom/browser-element/BrowserElementChild.js @@ -21,17 +21,17 @@ let infos = sendSyncMessage('browser-ele { 'msg_name': 'hello' })[0]; docShell.QueryInterface(Ci.nsIDocShellTreeItem).name = infos.name; docShell.setFullscreenAllowed(infos.fullscreenAllowed); if (!('BrowserElementIsPreloaded' in this)) { try { if (Services.prefs.getBoolPref("dom.mozInputMethod.enabled")) { - Services.scriptloader.loadSubScript("chrome://global/content/forms.js", global); + Services.scriptloader.loadSubScript("chrome://global/content/forms.js"); } } catch (e) { } // Those are produc-specific files that's sometimes unavailable. try { Services.scriptloader.loadSubScript("chrome://browser/content/ErrorPage.js"); } catch (e) { }
Attachment #828422 -
Attachment is obsolete: true
Attachment #829208 -
Flags: review+
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 829208 [details] [diff] [review] gecko patch v3 https://tbpl.mozilla.org/?tree=Try&rev=5ec7005b1b5c
Attachment #829208 -
Attachment is patch: true
Assignee | ||
Comment 15•11 years ago
|
||
Tested on device, The patch doesn't cause bug 936324 any more.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 16•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/4eea9a74a8bb Master: https://github.com/mozilla-b2g/gaia/commit/a4e3fc2252e11d70184dfdf681d4430184f23dab
Keywords: checkin-needed
Comment 17•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4eea9a74a8bb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•