932153 - A11Y_LOG will cause the build to burn when Gecko 27 moves from mozilla-aurora to mozilla-beta

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Phil Ringnalda (:philor)]

This is rather surprising, but https://tbpl.mozilla.org/?tree=Try&rev=f8ad0256dcf3 is the current tip of aurora, just after Gecko 27 merged to it, pushed to try as though it were beta, with among other things the update channel set to 'beta', and according to the burning builds that causes us to do what looks like correctly seeing that it's beta in accessible/src/shared.mozbuild and not building Logging.cpp as a result, but not seeing it's beta in accessible/src/Makefile.in and thus defining A11Y_LOG and expecting that Logging.cpp will have been compiled.

This only failing now (Gecko 26, the thing that's actually on beta now, is fine) seems rather weird, since neither the makefile nor the moz.build file appear to have been touched in a way likely to change that.

Comment 1

[Mike Hommey [:glandium]]

Oh my... Makefiles under accessible/src/* are relying on A11Y_LOG being exported from accessible/src/Makefile.in. Which is not the case when doing derecursed build nowadays. It's also not the case when doing make -C objdir/accessible/src/foo, so it was wrong to do that in the first place.

Backing out the removal of 'test -n "$DEVELOPER_OPTIONS"' from bug 926126 could be something we can land on aurora safely (no need to backout the MOZ_PSEUDO_DERECURSE value change).

Alternatively, A11Y_LOG could be moved to accessible/src/defs.mk, in which case it will be inherited by all submakefiles.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Move A11Y_LOG to accessible/src/defs.mk

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 823761 [details] [diff] [review]
Move A11Y_LOG to accessible/src/defs.mk

Philor, can you test this? It should be good enough to land on m-c and aurora.

Comment 4

[Phil Ringnalda (:philor)]

Sure, https://tbpl.mozilla.org/?tree=Try&rev=5e3a9ec1b96a

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 823761 [details] [diff] [review]
Move A11Y_LOG to accessible/src/defs.mk

Looks like this worked.

Comment 7

[Ed Morley [:emorley]]

(This is keeping aurora closed currently)

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 823761 [details] [diff] [review]
Move A11Y_LOG to accessible/src/defs.mk

This looks good to me. Reviewing for gps since it's causing sheriff pain.

Comment 9

[Gregory Szorc [:gps]]

Sorry for not seeing this. I woke up with 14 new reviews in my queue. I'm about half in and I still have unread bugmail. IRC pings would have helped. Next time.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

RyanVM: (autoresponse) content-free ping detected. Please consider providing some additional context so I can address your questions more efficiently.

Comment 11

[Gregory Szorc [:gps]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> RyanVM: (autoresponse) content-free ping detected. Please consider providing
> some additional context so I can address your questions more efficiently.

I don't see a ping earlier than 13:18 my time. Whatevs. We got review.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2508d56d93e
https://hg.mozilla.org/releases/mozilla-aurora/rev/ff853b777411

Will trigger new nightlies on Aurora to confirm.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

An hour in and the nightlies are still going. I think we're in good shape here :)

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2508d56d93e

Comment 15

[Tracy Walker [:tracy]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #13)
> An hour in and the nightlies are still going. I think we're in good shape
> here :)

Does this mean, once 27 goes to Beta, those builds won't go up in flames?

Comment 16

[Phil Ringnalda (:philor)]

It does, I've pushed aurora-as-beta and trunk-as-aurora-with-aurora's-channel to try a couple of times since this landed.

Comment 17

[Tracy Walker [:tracy]]

Excellent, thank you, philor!