Closed
Bug 932154
Opened 11 years ago
Closed 11 years ago
Define postRILMessage with the right argument length.
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
957 bytes,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
Bug 814579 added a new argument to postRILMessage, but did not update the "number of arguments" argument to JS_DefineFunction. This is fine for the actual function call, since JS functions accept any number of arguments, but it will cause postRILMessage.length to return 1 instead of the correct 2.
Patch coming.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #823755 -
Flags: review?(vyang)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 823755 [details] [diff] [review]
Patch
Review of attachment 823755 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you :)
Attachment #823755 -
Flags: review?(vyang) → review+
|
|
||
Comment 3•11 years ago
|
||
Just a remind after bug 920551, RIL IPC code has been moved to ipc/ril/Ril.cpp, so rebase is required.
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•