Closed Bug 932154 Opened 6 years ago Closed 6 years ago

Define postRILMessage with the right argument length.

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Bug 814579 added a new argument to postRILMessage, but did not update the "number of arguments" argument to JS_DefineFunction.  This is fine for the actual function call, since JS functions accept any number of arguments, but it will cause postRILMessage.length to return 1 instead of the correct 2.

Patch coming.
Comment on attachment 823755 [details] [diff] [review]
Patch

Review of attachment 823755 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #823755 - Flags: review?(vyang) → review+
Just a remind after bug 920551, RIL IPC code has been moved to ipc/ril/Ril.cpp, so rebase is required.
https://hg.mozilla.org/mozilla-central/rev/599442dc0da7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.