932216 - Remove code conditional on JS_HAS_CONST, JS_HAS_BLOCK_SCOPE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andy Wingo [:wingo]]

Const is a part of the web.  Let will be a part of ES6, somehow.  Remove code conditional on these defines, and reword Keywords.h to reflect 1JS.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Remove code conditional on JS_HAS_CONST, JS_HAS_BLOCK_SCOPE

Comment 2

[Luke Wagner [:luke]]

Perhaps JS_HAS_DESTRUCTURING as well?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Andy Wingo [:wingo] from comment #0)
> Const is a part of the web.

Oh?

Comment 4

[Andy Wingo [:wingo]]

(In reply to :Ms2ger from comment #3)
> (In reply to Andy Wingo [:wingo] from comment #0)
> > Const is a part of the web.
> 
> Oh?

Sure.  Not defined, but treating it as a token is web-compatible.  Also it will be in ES6.

Comment 5

[Andy Wingo [:wingo]]

(In reply to Luke Wagner [:luke] from comment #2)
> Perhaps JS_HAS_DESTRUCTURING as well?

A good idea; didn't think of it because I was just concerned about the keyword list :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13bd430455d4

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13bd430455d4