Remove code conditional on JS_HAS_CONST, JS_HAS_BLOCK_SCOPE

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wingo, Assigned: wingo)

Tracking

unspecified
mozilla28
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Const is a part of the web.  Let will be a part of ES6, somehow.  Remove code conditional on these defines, and reword Keywords.h to reflect 1JS.
(Assignee)

Comment 1

4 years ago
Created attachment 823911 [details] [diff] [review]
Remove code conditional on JS_HAS_CONST, JS_HAS_BLOCK_SCOPE
(Assignee)

Updated

4 years ago
Assignee: nobody → wingo
(Assignee)

Updated

4 years ago
Attachment #823911 - Flags: review?(jorendorff)
(Assignee)

Updated

4 years ago
Blocks: 932276

Comment 2

4 years ago
Perhaps JS_HAS_DESTRUCTURING as well?
Attachment #823911 - Flags: review?(jorendorff) → review+
(In reply to Andy Wingo [:wingo] from comment #0)
> Const is a part of the web.

Oh?
(Assignee)

Comment 4

4 years ago
(In reply to :Ms2ger from comment #3)
> (In reply to Andy Wingo [:wingo] from comment #0)
> > Const is a part of the web.
> 
> Oh?

Sure.  Not defined, but treating it as a token is web-compatible.  Also it will be in ES6.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
(In reply to Luke Wagner [:luke] from comment #2)
> Perhaps JS_HAS_DESTRUCTURING as well?

A good idea; didn't think of it because I was just concerned about the keyword list :)

Comment 7

4 years ago
https://hg.mozilla.org/mozilla-central/rev/13bd430455d4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.