932223 - External apps split in two folders during make process

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Albert [:albert]]

External apps are split in two folders during make gaia process.

For a given application 'app' two folders are generated in webapps/profile:
'app' and 'app.gaiamobile.org'

Comment 1

[Albert [:albert]]

Attachment: Patch

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Albert, do you know the root cause? looks we will have two times to generate zip file for same app.

Comment 3

[Albert [:albert]]

For external apps, webapp-manifests.js copies data to 'sourceDirectoryName' (f.e. gamepack) and then, webapp-zip.js generates the zip in 'domain' (gamepack.gaiamobile.org). The result is profile contains both folders.

External apps doesn't need to generate the zip, so patch copies data in webapp-manifests.js and does nothing in webapp-zip.js

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

ni? Fabrice for question on github[1]

[1] https://github.com/mozilla-b2g/gaia/pull/13185/files#r7393351

Comment 5

[[:fabrice] Fabrice Desré]

Sorry I didn't see that you pinged me on github. The metadata.json is not needed in the shipped profile. It's only used to set correct values in webapps.json for the app.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 824050 [details]
Patch

Thank you Fabrice!

and r=yurenju if comments on github are addressed.

Comment 7

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/31687ef383bc1b85a9d388fb3dde610ab7e8f8fd