Closed Bug 932295 Opened 8 years ago Closed 8 years ago

Android video capture should autofocus

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: ted, Assigned: rbarker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

autofocus2.patch
2.25 KB, patch
Details | Diff | Splinter Review 
It would be nice if the video capture (via getUserMedia) on Android did autofocus. Without this it makes it hard to get a clear image of things.
Assignee: nobody → rbarker
Attached patch focus1.patch (obsolete) — — Splinter Review 
From what I have read, this seems to be what is being requested. Still working on verifying that it actually works. Of course this will only work with most rear facing cameras since most phone front facing cameras don't support auto focus as I understand it.
Attachment #8334978 - Flags: feedback?(gpascutto)
Comment on attachment 8334978 [details] [diff] [review]
focus1.patch

Review of attachment 8334978 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8334978 - Flags: feedback?(gpascutto) → feedback+
If you can spin a try build or upload a locally-built APK with this patch I'd be happy to test it. Using autofocus only on hardware that has it available is completely sensible.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> If you can spin a try build or upload a locally-built APK with this patch
> I'd be happy to test it. Using autofocus only on hardware that has it
> available is completely sensible.

I uploaded a locally built apk here:

https://people.mozilla.org/~rbarker/fennec-28.focus.apk
This seems to do exactly what I'd expect. Thanks!
This can't land until it has r+. Also, please make sure the patch includes the necessary commit information.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
Randall, anything holding this back?
Nothing, I know of.
Attachment #8334978 - Flags: review?(gpascutto)
Comment on attachment 8334978 [details] [diff] [review]
focus1.patch

Review of attachment 8334978 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but add the author and a sane commit message.
Attachment #8334978 - Flags: review?(gpascutto) → review+
Attached patch autofocus.patch (obsolete) — — Splinter Review 
Rebased and correct commit message.
Attachment #8334978 - Attachment is obsolete: true
Attached patch autofocus.patch (obsolete) — — Splinter Review 
Updated to HG diff.
Attachment #8343997 - Attachment is obsolete: true
Attached patch autofocus2.patch — — Splinter Review 
Attempt to get patch correctly formatted.
Attachment #8344000 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fb7bdd450ebd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Blocks: 950479
You need to log in before you can comment on or make changes to this bug.