Closed
Bug 932295
Opened 7 years ago
Closed 7 years ago
Android video capture should autofocus
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: ted, Assigned: rbarker)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
2.25 KB,
patch
|
Details | Diff | Splinter Review |
It would be nice if the video capture (via getUserMedia) on Android did autofocus. Without this it makes it hard to get a clear image of things.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rbarker
Assignee | ||
Comment 1•7 years ago
|
||
From what I have read, this seems to be what is being requested. Still working on verifying that it actually works. Of course this will only work with most rear facing cameras since most phone front facing cameras don't support auto focus as I understand it.
Attachment #8334978 -
Flags: feedback?(gpascutto)
Comment 2•7 years ago
|
||
Comment on attachment 8334978 [details] [diff] [review] focus1.patch Review of attachment 8334978 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8334978 -
Flags: feedback?(gpascutto) → feedback+
Reporter | ||
Comment 3•7 years ago
|
||
If you can spin a try build or upload a locally-built APK with this patch I'd be happy to test it. Using autofocus only on hardware that has it available is completely sensible.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3) > If you can spin a try build or upload a locally-built APK with this patch > I'd be happy to test it. Using autofocus only on hardware that has it > available is completely sensible. I uploaded a locally built apk here: https://people.mozilla.org/~rbarker/fennec-28.focus.apk
Reporter | ||
Comment 5•7 years ago
|
||
This seems to do exactly what I'd expect. Thanks!
Updated•7 years ago
|
Keywords: checkin-needed
Comment 6•7 years ago
|
||
This can't land until it has r+. Also, please make sure the patch includes the necessary commit information. https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
Comment 7•7 years ago
|
||
Randall, anything holding this back?
Assignee | ||
Comment 8•7 years ago
|
||
Nothing, I know of.
Assignee | ||
Updated•7 years ago
|
Attachment #8334978 -
Flags: review?(gpascutto)
Comment 9•7 years ago
|
||
Comment on attachment 8334978 [details] [diff] [review] focus1.patch Review of attachment 8334978 [details] [diff] [review]: ----------------------------------------------------------------- r+ but add the author and a sane commit message.
Attachment #8334978 -
Flags: review?(gpascutto) → review+
Assignee | ||
Comment 10•7 years ago
|
||
Rebased and correct commit message.
Attachment #8334978 -
Attachment is obsolete: true
Assignee | ||
Comment 11•7 years ago
|
||
Updated to HG diff.
Assignee | ||
Updated•7 years ago
|
Attachment #8343997 -
Attachment is obsolete: true
Assignee | ||
Comment 12•7 years ago
|
||
Attempt to get patch correctly formatted.
Attachment #8344000 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/fb7bdd450ebd
Keywords: checkin-needed
Comment 14•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb7bdd450ebd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•