932295 - Android video capture should autofocus

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[(not currently active) Ted Mielczarek]

It would be nice if the video capture (via getUserMedia) on Android did autofocus. Without this it makes it hard to get a clear image of things.

Comment 1

[Randall Barker [:rbarker]]

Attachment: focus1.patch

From what I have read, this seems to be what is being requested. Still working on verifying that it actually works. Of course this will only work with most rear facing cameras since most phone front facing cameras don't support auto focus as I understand it.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8334978 [details] [diff] [review]
focus1.patch

Review of attachment 8334978 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[(not currently active) Ted Mielczarek]

If you can spin a try build or upload a locally-built APK with this patch I'd be happy to test it. Using autofocus only on hardware that has it available is completely sensible.

Comment 4

[Randall Barker [:rbarker]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> If you can spin a try build or upload a locally-built APK with this patch
> I'd be happy to test it. Using autofocus only on hardware that has it
> available is completely sensible.

I uploaded a locally built apk here:

https://people.mozilla.org/~rbarker/fennec-28.focus.apk

Comment 5

[(not currently active) Ted Mielczarek]

This seems to do exactly what I'd expect. Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This can't land until it has r+. Also, please make sure the patch includes the necessary commit information.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Randall, anything holding this back?

Comment 8

[Randall Barker [:rbarker]]

Nothing, I know of.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8334978 [details] [diff] [review]
focus1.patch

Review of attachment 8334978 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but add the author and a sane commit message.

Comment 10

[Randall Barker [:rbarker]]

Attachment: autofocus.patch

Rebased and correct commit message.

Comment 11

[Randall Barker [:rbarker]]

Attachment: autofocus.patch

Updated to HG diff.

Comment 12

[Randall Barker [:rbarker]]

Attachment: autofocus2.patch

Attempt to get patch correctly formatted.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fb7bdd450ebd

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb7bdd450ebd

Comment 15

[pranshukumar1999]

int bufSize = width * height * pixelFormat.bitsPerPixel / 8;

I wanted to ask about this line. Is it using an 8-bit color scheme? If so then why? Why can't we use any greater ones as there are high res displays now also I wanted to ask can it have a dynamic variable instead of n(in this case 8)?