Closed Bug 932301 Opened 12 years ago Closed 12 years ago

Localization of badge descriptions is sometimes broken.

Categories

(support.mozilla.org :: Localization, task, P3)

Product:
support.mozilla.org
Component:
Localization
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013Q4

People

(Reporter: rrosario, Assigned: willkg)

Details

(Whiteboard: u=contributor c=badges p=0 s=2013.22)

I am not sure what's going on but depending on the contents of the description, gettext seems to fail to get the translation. For example, this works: https://support.mozilla.org/it/badges/badge/kitsune-contributor But this doesn't: https://support.mozilla.org/it/badges/badge/2013-l10n-badge One big difference is the multiple lines and whitespace in between sentences of the longer latter description
Grabbing this one to look into. I'm getting a new dump now. I'll double-check Ricky's observations and then put on my BizarroInsulation suit (+10 vs. gettext weirdness) and do a quick dive to see what's going on.
Assignee: nobody → willkg
What's going on is that extracting db strings into the db_strings.py file doesn't collapse whitespace. When Tower does its gettext thing, it collapses the whitespace and at that point the string doesn't match a msgid and therefore doesn't get translated. In a PR: https://github.com/mozilla/kitsune/pull/1700
Making this a 0 point bug because I'm not in this sprint.
Whiteboard: u=contributor c=badges p= s=2013.22 → u=contributor c=badges p=0 s=2013.22
Landed in master in https://github.com/mozilla/kitsune/commit/dfb410d We don't need to push this to production, but do need to do a string extract-and-merge. Ricky said he'd coordinate that soon. As such, I'm marking it FIXED.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.